From 067151fd7dd1111ccf47c77c06bb196a2e3e1913 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 8 Apr 2024 10:30:05 -0400 Subject: [PATCH] build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.8.3 to 4.8.4 (#368) * build(deps): bump com.github.spotbugs:spotbugs-maven-plugin Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.8.2.0 to 4.8.3.1. - [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases) - [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.8.2.0...spotbugs-maven-plugin-4.8.3.1) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] * build(deps): bump com.github.spotbugs:spotbugs-annotations Bumps [com.github.spotbugs:spotbugs-annotations](https://github.com/spotbugs/spotbugs) from 4.8.3 to 4.8.4. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.8.3...4.8.4) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs-annotations dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] * add final finalize() method to avoid potential finalizer attack --------- Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Azores --- pom.xml | 4 ++-- src/main/java/io/cryostat/core/agent/AgentJMXHelper.java | 3 +++ src/main/java/io/cryostat/core/agent/CapturedValue.java | 3 +++ src/main/java/io/cryostat/core/agent/Event.java | 3 +++ 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 8439ea5e..92c2209a 100644 --- a/pom.xml +++ b/pom.xml @@ -78,8 +78,8 @@ 1.11.0 1.16.1 - 4.8.3 - 4.8.2.0 + 4.8.4 + 4.8.3.1 5.10.2 2.2 5.2.0 diff --git a/src/main/java/io/cryostat/core/agent/AgentJMXHelper.java b/src/main/java/io/cryostat/core/agent/AgentJMXHelper.java index b3c78ed3..1f57857c 100644 --- a/src/main/java/io/cryostat/core/agent/AgentJMXHelper.java +++ b/src/main/java/io/cryostat/core/agent/AgentJMXHelper.java @@ -107,6 +107,9 @@ public void defineEventProbes(String xmlDescription) throws ProbeDefinitionExcep } } + @Override + protected final void finalize() {} + static class ProbeDefinitionException extends Exception { ProbeDefinitionException(String message, Throwable e) { super(message, e); diff --git a/src/main/java/io/cryostat/core/agent/CapturedValue.java b/src/main/java/io/cryostat/core/agent/CapturedValue.java index f71bfb48..fc1d5265 100644 --- a/src/main/java/io/cryostat/core/agent/CapturedValue.java +++ b/src/main/java/io/cryostat/core/agent/CapturedValue.java @@ -205,6 +205,9 @@ public void setConverter(String converter) { this.converter = converter; } + @Override + protected final void finalize() {} + protected void copyContentToWorkingCopy(CapturedValue copy) { copy.name = name; copy.description = description; diff --git a/src/main/java/io/cryostat/core/agent/Event.java b/src/main/java/io/cryostat/core/agent/Event.java index 01409016..5e4c5afc 100644 --- a/src/main/java/io/cryostat/core/agent/Event.java +++ b/src/main/java/io/cryostat/core/agent/Event.java @@ -231,4 +231,7 @@ private Element buildMethodElement(Document document) { return methodElement; } + + @Override + protected final void finalize() {} }