Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Test Smart Triggers with downgraded protobuf #261

Closed
andrewazores opened this issue Nov 23, 2023 · 0 comments · Fixed by #262
Closed

[Task] Test Smart Triggers with downgraded protobuf #261

andrewazores opened this issue Nov 23, 2023 · 0 comments · Fixed by #262
Assignees
@andrewazores
Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file question Further information is requested

Comments

@andrewazores
Copy link
Member 

          > @ebaron any issues with building this update downstream?

The only problem I see is a growing gap between the protobuf version available:

  • 3.25.1 here
  • 3.22.3 downstream

I think these should still be compatible, but I'm not certain.

Originally posted by @ebaron in #254 (comment)
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file question Further information is requested labels Nov 23, 2023
@andrewazores andrewazores mentioned this issue Nov 23, 2023
Merged
@andrewazores andrewazores self-assigned this Nov 23, 2023
@andrewazores andrewazores mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewazores andrewazores

Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(cel): force override protobuf transitive dep used by CEL andrewazores/cryostat-agent
1 participant
@andrewazores