Skip to content

Commit ce56c95

Browse files
committed
Make classes final if they're not meant to be derived from
1 parent 1c33006 commit ce56c95

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

src/CopyDevice.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ namespace copyfs {
1111

1212
namespace bf = boost::filesystem;
1313

14-
class CopyDevice: public fspp::Device {
14+
class CopyDevice final: public fspp::Device {
1515
public:
1616
explicit CopyDevice(const bf::path &rootdir);
17-
virtual ~CopyDevice();
17+
~CopyDevice();
1818

1919
void statfs(const boost::filesystem::path &path, struct ::statvfs *fsstat) override;
2020

src/CopyDir.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88

99
namespace copyfs {
1010

11-
class CopyDir: public fspp::Dir, CopyNode {
11+
class CopyDir final: public fspp::Dir, CopyNode {
1212
public:
1313
CopyDir(CopyDevice *device, const bf::path &path);
14-
virtual ~CopyDir();
14+
~CopyDir();
1515

1616
//TODO return type variance to CopyFile/CopyDir?
1717
cpputils::unique_ref<fspp::OpenFile> createAndOpenFile(const std::string &name, mode_t mode, uid_t uid, gid_t gid) override;

src/CopyFile.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77

88
namespace copyfs {
99

10-
class CopyFile: public fspp::File, CopyNode {
10+
class CopyFile final: public fspp::File, CopyNode {
1111
public:
1212
CopyFile(CopyDevice *device, const boost::filesystem::path &path);
13-
virtual ~CopyFile();
13+
~CopyFile();
1414

1515
cpputils::unique_ref<fspp::OpenFile> open(int flags) const override;
1616
void truncate(off_t size) const override;

src/CopyOpenFile.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
namespace copyfs {
99
class CopyDevice;
1010

11-
class CopyOpenFile: public fspp::OpenFile {
11+
class CopyOpenFile final: public fspp::OpenFile {
1212
public:
1313
CopyOpenFile(const CopyDevice *device, const boost::filesystem::path &path, int flags);
14-
virtual ~CopyOpenFile();
14+
~CopyOpenFile();
1515

1616
void stat(struct ::stat *result) const override;
1717
void truncate(off_t size) const override;

src/CopySymlink.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77

88
namespace copyfs {
99

10-
class CopySymlink: public fspp::Symlink, CopyNode {
10+
class CopySymlink final: public fspp::Symlink, CopyNode {
1111
public:
1212
CopySymlink(CopyDevice *device, const bf::path &path);
13-
virtual ~CopySymlink();
13+
~CopySymlink();
1414

1515
boost::filesystem::path target() const override;
1616
void remove() override;

0 commit comments

Comments
 (0)