Merge branch 'development'

Author: patricioe

CHANGES.txt

@@ -1,3 +1,6 @@
+4.2.1 (July 20, 2017)
+- Coerce string to regexp for Regexp matcher
+
 4.2.0 (July 18, 2017)
 - Add new boolean/regexp matchers
 - Add support for split dependency on other splits

Detailed-README.md

@@ -424,22 +424,41 @@ Currently SDK supports:
 
 Other servers should work fine as well, but haven't been tested.
 
-### Unicorn
+### Unicorn and Puma in cluster mode (only for "memory mode")
 
-If you're using Unicorn in the `memory` mode you'll need to include this line in your unicorn config (probably `config/unicorn.rb`):
+During the start of your application SDK spawns multiple threads, each thread has an infinite loop inside which is used to fetch splits/segments or send impressions/metrics.
+Several servers like Unicorn and Puma in cluster mode (i.e. with `workers` > 0) spawn multiple child processes, but when child process is spawn it does not recreate threads, which existed in the parent process, that's why if you use Unicorn or Puma in cluster mode you need to make two small extra steps.
+
+For both servers you will need to have the following line in your `config/initializers/splitclient.rb`:
+
+```ruby
+Rails.configuration.split_factory = factory
+```
+
+#### Unicorn
+
+If you're using Unicorn you'll need to include this line in your Unicorn config (probably `config/unicorn.rb`):
 
 ```ruby
 after_fork do |server, worker|
   Rails.configuration.split_factory.resume! if worker.nr > 0
 end
 ```
 
-Also, you will need to have the following line in your `config/initializers/splitclient.rb`:
+By doing that SDK will recreate threads for each new worker, besides master.
+
+#### Puma
+
+For those who use Puma in cluster mode add this to your Puma config (probably `config/puma.rb`):
 
 ```ruby
-Rails.configuration.split_factory = factory
+on_worker_boot do |worker_number|
+  Rails.configuration.split_factory.resume! if worker_number.nr > 0
+end
 ```
 
+By doing that SDK will recreate threads for each new worker, besides master.
+
 ## Framework support
 
 Currently SDK supports:

lib/splitclient-rb/engine/matchers/matches_string_matcher.rb

@@ -6,18 +6,13 @@ def self.matcher_type
 
     def initialize(attribute, regexp_string)
       @attribute = attribute
-      @regexp_string = regexp_string
+      @regexp_string = @regexp_string.is_a?(Regexp) ? regexp_string : Regexp.new(regexp_string)
     end
 
     def match?(_matching_key, _bucketing_key, _evaluator, data)
       value = data.fetch(@attribute) { |attr| data[attr.to_s] || data[attr.to_sym] }
 
-      if @regexp_string.is_a? Regexp
-        (value =~ @regexp_string) != nil
-      else
-        # String here
-        value == @regexp_string
-      end
+      (value =~ @regexp_string) != nil
     end
   end
 end

lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '4.2.0'
+  VERSION = '4.2.1'
 end