Skip to content

Commit 15df832

Browse files
committed
Add more details to comment
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
1 parent cbb6d9e commit 15df832

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pkg/reconciler/managed/reconciler.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1269,8 +1269,12 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (resu
12691269

12701270
if observation.ResourceExists {
12711271
// When a resource exists or is just created, it might have received
1272-
// a non-deterministic external name, which we need to persist.
1272+
// a non-deterministic external name after its creation, which we need to persist.
12731273
// We do this by updating the critical annotations.
1274+
// This is needed because some resources might not receive an external-name directly
1275+
// after the creation, but later as part of an asynchronous process.
1276+
// When Crossplane supports asynchronous creation of resources natively, this logic
1277+
// might not be needed anymore and can be revisited.
12741278
if err := r.managed.UpdateCriticalAnnotations(ctx, managed); err != nil {
12751279
log.Debug(errUpdateManagedAnnotations, "error", err)
12761280
record.Event(managed, event.Warning(reasonCannotUpdateManaged, errors.Wrap(err, errUpdateManagedAnnotations)))

0 commit comments

Comments
 (0)