Capture stdout and stderr even if cmd.Run fails
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mproffitt
force-pushed
the
rework-shell-execution
branch
from
fb34de0 to
7c9454c
Compare
|
Leaving in draft until this has been tested fully inside a cluster |
In its current form, if `cmd.Run` fails, then the function immediately exits with no reason given for the termination. This makes debugging scripts hard to understand as no indication is given for the failure, other than a failure occured. By trapping the error returned from `cmd.Run`, we first process the buffers for both `stdout` and `stderr` and set these to the `dxr`. Additionally we capture a truncated `stderr` from the command error which can help point to where the command failed, setting this as the Fatal error message returned as an event. Signed-off-by: Martin Proffitt <mproffitt@choclab.net>
mproffitt
force-pushed
the
rework-shell-execution
branch
from
7c9454c to
4dbbc02
Compare
|
Hello @mproffitt can you indicate what kind of testing you have done in-cluster for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In its current form, if
cmd.Runfails, then the function immediately exits with no reason given for the termination. This makes debugging scripts hard to understand as no indication is given for the failure, other than a failure occured.By trapping the error returned from
cmd.Run, we first process the buffers for bothstdoutandstderrand set these to thedxr.Additionally we capture a truncated
stderrfrom the command error which can help point to where the command failed, setting this as the Fatal error message returned as an event.Both
stderrandstdoutare also pushed to the debug log before returning fatal on error to ensure all information available to the function is also available to the end user for debugging purposes.I have:
contribution process. Also see docs.