New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XBR: fix or replace pysha3 build on PyPy #1247

Open

oberstet opened this issue Sep 15, 2019 · 0 comments

Labels

bug CI-CD PRIO HIGH wamp XBR

Contributor

oberstet commented Sep 15, 2019 •

edited

Loading

the build fails, see https://gist.github.com/oberstet/fec756b9489a8b046bfd28813bfe2de1

reason: pysha3 uses CPyExt - I have no clue why they did that, nor why they use CPyExt

background: ehtereum uses keccack256 for hashing, a pre-standard sha3-256 variant

the python 3.6+ standard library contains that variant:

New in version 3.6: SHA3 (Keccak) and SHAKE constructors sha3_224(), sha3_256(), sha3_384(), sha3_512(), shake_128(), shake_256().

oberstet added wamp bug CI-CD PRIO HIGH XBR labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment