-
Notifications
You must be signed in to change notification settings - Fork 410
Support crosstool for uclibc, musl, and newlib. #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -32,6 +36,15 @@ pub struct ConfigureCrosstool { | |||
/// The glibc version to configure for. | |||
#[clap(long, env = "GLIBC_VERSION")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all optional, and use default versions if not provided. It detects the correct libc to use by the name: if it contains gnu
, it's a glibc target, uclibc
is uclibc
, musl
is musl, and none
is newlib.
let linux_patch = linux_versions.get(2).unwrap_or(&"0").parse::<u32>()?; | ||
let ct_linux_v = format!( | ||
"CT_LINUX_V_{linux_major}_{linux_minor}=y | ||
if file_name.contains("linux") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we now support newlib targets, Linux needs to be optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, otherwise looks good
What's the nit? |
eeh, strange, it didn't get added... |
bors r=Emilgardis |
bors r- |
Canceled. |
Pre-1.0 uclibc support, at least from the configuration standpoint has been fixed. I'm diagnosing some other errors, but those are limited to compiler and Linux versions during the build process, and not the config itself (specifically, a missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded: |
No description provided.