Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix tags in android images with ndk, sdk and os #1155

Open
1 of 2 tasks
Emilgardis opened this issue Nov 23, 2022 · 4 comments
Open
1 of 2 tasks

prefix tags in android images with ndk, sdk and os #1155

Emilgardis opened this issue Nov 23, 2022 · 4 comments

Comments

@Emilgardis
Copy link
Member

Checklist

Describe your request

We should consider if we should rename the android images to *-linux-androideabi:ndkxxy-sdkxx-osxx-<branch>

Describe why this would be a good inclusion for cross

This would mean less confusion about what is included, and make it easier to maintain multiple versions without much effort (as build-docker-image could inject it for you`

@Emilgardis
Copy link
Member Author

Emilgardis commented Nov 23, 2022

I do think it's worth it to keep a simple :main/vx.y.z tag, but on top of that we could provide extra tags

@Alexhuszagh Alexhuszagh added container-images A-android Area: android targets labels Nov 23, 2022
@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Nov 23, 2022

Would we then do multiple deployments, or a single deployment? If so, I think we only would need 1 NDK version (the latest, or r25b right now) and then 1 version at each major version. If we do the latter, we would ideally use our targets.toml to specify the versions. If not, we probably still need a single entry in targets.toml just so we don't hard-code it build-docker-image.

@berendsliedrecht
Copy link

berendsliedrecht commented Jan 27, 2023

Hi, I am running into the same issues specified in #1195. Right now I wanted to fix it by passing ANDROID_NDK as an environment variable and I hoped the image would pick it up. Would something like that not be an easier solution? I think if we let users pass in the ndk/sdk/etc. versions from env vars there is no need for an infinite amount of images, right?

Maybe something like this:

[target.armv7-linux-androideabi]
image = "ghcr.io/cross-rs/armv7-linux-androideabi:main"
build-args = ["ANDROID_NDK=r24", "ANDROID_SDK=21", "ANDROID_VERSION=5.0.0_r1"]

@Emilgardis
Copy link
Member Author

I dont think we should have multiple ndks in an image, that would be a huge image and take an imense amount of CI time in one step. What we could do is allow something similar where if you dont provide an explicit image, cross recognizes the env var ANDROID_NDK etc and uses the appropriate image if it exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants