-
-
Notifications
You must be signed in to change notification settings - Fork 273
Use Converse API for Bedrock provider #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding Converse API is a great idea but this PR has significant issues:
- No tests!
- Code complexity
- It doesn't follow the lead of the other providers in terms of method names, modules, etc.
- Overcommit was not installed
@crmne Several changes made per your comments. Well tested and ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 84.57% 84.57%
=======================================
Files 37 37
Lines 1932 1932
Branches 499 499
=======================================
Hits 1634 1634
Misses 298 298 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big patch @richet so thank you for the effort but there are still significant changes needed:
I still see that the organization of the code, especially in chat.rb
, doesn't respect the organization of the other providers. There are a ton of methods there that belong in other modules in a provider implementation. Check the OpenAI provider for an example of what belongs where. I'll resume reviewing it when that's done.
Thank you again for the monumental effort.
@crmne Thanks for the review and pushing me to clean this up a bit more. I renamed and cleaned up a lot of the methods to a point where I think its close to what you have in OpenAI. |
What this does
Type of change
Scope check
Quality check
overcommit --install
and all hooks passmodels.json
,aliases.json
)API changes
Related issues