Filter remote providers when fetching models and simplify specs for refresh method

Author: crmne

lib/ruby_llm/models.rb

@@ -37,7 +37,7 @@ def refresh!
       end
 
       def fetch_from_providers
-        configured = Provider.configured_providers(RubyLLM.config)
+        configured = Provider.configured_providers(RubyLLM.config).filter(&:remote?)
 
         RubyLLM.logger.info "Fetching models from providers: #{configured.map(&:slug).join(', ')}"
 

spec/ruby_llm/models_spec.rb

@@ -78,42 +78,24 @@
   end
 
   describe '#refresh!' do
-    it 'updates models and returns a chainable Models instance' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
-      # Use a temporary file to avoid modifying actual models.json
-      temp_file = Tempfile.new(['models', '.json'])
-      allow(File).to receive(:expand_path).with('models.json', any_args).and_return(temp_file.path)
-
-      begin
-        # Refresh and chain immediately
-        chat_models = RubyLLM.models.refresh!.chat_models
-
-        # Verify we got results
-        expect(chat_models).to be_a(described_class)
-        expect(chat_models.all).to all(have_attributes(type: 'chat'))
-
-        # Verify we got models from at least OpenAI and Anthropic
-        providers = chat_models.map(&:provider).uniq
-        expect(providers).to include('openai', 'anthropic')
-      ensure
-        temp_file.close
-        temp_file.unlink
-      end
-    end
+    it 'updates models and returns a chainable Models instance' do # rubocop:disable RSpec/MultipleExpectations
+      # Refresh and chain immediately
+      chat_models = RubyLLM.models.refresh!.chat_models
 
-    it 'works as a class method too' do # rubocop:disable RSpec/ExampleLength
-      temp_file = Tempfile.new(['models', '.json'])
-      allow(File).to receive(:expand_path).with('models.json', any_args).and_return(temp_file.path)
+      # Verify we got results
+      expect(chat_models).to be_a(described_class)
+      expect(chat_models.all).to all(have_attributes(type: 'chat'))
 
-      begin
-        # Call class method
-        described_class.refresh!
+      # Verify we got models from at least OpenAI and Anthropic
+      providers = chat_models.map(&:provider).uniq
+      expect(providers).to include('openai', 'anthropic')
+    end
 
-        # Verify singleton instance was updated
-        expect(RubyLLM.models.all.size).to be > 0
-      ensure
-        temp_file.close
-        temp_file.unlink
-      end
+    it 'works as a class method too' do
+      described_class.refresh!
+
+      # Verify singleton instance was updated
+      expect(RubyLLM.models.all.size).to be > 0
     end
   end