Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prefetch feature #255

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Remove prefetch feature #255

wants to merge 9 commits into from

Conversation

TurpIF
Copy link
Contributor

@TurpIF TurpIF commented May 30, 2022

No description provided.

@TurpIF TurpIF force-pushed the remove-prefetch branch 2 times, most recently from 3c217cd to b55a2f8 Compare May 31, 2022 05:28
@TurpIF
🚩 Disable prefetch on init per default for all tests
2ecf5f4 
This also adapt tests by removing those on prefetch or simulating the
prefetch until bid caching is removed.

JIRA: DPP-4000
JIRA: DPP-3999
@TurpIF TurpIF force-pushed the remove-prefetch branch 2 times, most recently from 3425c37 to 570b7a6 Compare May 31, 2022 05:40
@TurpIF
🔥 Stop calling prefetch at SDK init
da73519 
Dead code will be removed after this commit

JIRA: DPP-4000
@TurpIF TurpIF force-pushed the remove-prefetch branch 4 times, most recently from 1ff18f1 to d2f6cb8 Compare June 1, 2022 05:29
@TurpIF
🔥 Remove prefetch entry point in BidManager and Config
927f4b4 
JIRA: DPP-4000
@TurpIF
🔥 Remove the ability to group ad unit requests by chunks
89cf262 
As it was only used by prefetch, we can remove all the ability to load
multiple bids at once.

JIRA: DPP-4000
@TurpIF
🔥 Remove the ability to send multiple slot per bid request
e906992 
The CDB model still allow this but without prefetch, there is no way to
request many slots. Hence, for now it is removed to reduce the technical
debt.

JIRA: DPP-4000
@TurpIF
🔥 Remove call to Criteo$Builder#adUnits
ae7fee8 
JIRA: DPP-4000
@TurpIF
✅ Update CSM tests for live bidding without prefetch
33f174d 
JIRA: DPP-4000
@TurpIF
📝 Remove prefetch terminology
28a3ebb
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TurpIF TurpIF marked this pull request as ready for review June 1, 2022 13:25
@TurpIF TurpIF requested a review from a team as a code owner June 1, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardlabat leonardlabat Awaiting requested review from leonardlabat leonardlabat is a code owner automatically assigned from criteo/publisher-sdk

@afewcc afewcc Awaiting requested review from afewcc afewcc is a code owner automatically assigned from criteo/publisher-sdk

@Pgb-Criteo Pgb-Criteo Awaiting requested review from Pgb-Criteo Pgb-Criteo is a code owner automatically assigned from criteo/publisher-sdk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TurpIF