Skip to content

Commit 3f1fbae

Browse files
authored
Fix continueBeforeSteadyState (pulumi#914)
* Fix continueBeforeSteadyState The docs say this should default to `false`, and the implementation appears to be trying to implement that, but it applies `!` to an `Output` value, which will always be `false`, even if the `Output` internally evaluates to `false`. Instead, apply the `!` inside an apply. Also remove accidentally added debug logging. Fixes pulumi#902. * Add CHANGELOG * Lint
1 parent ef461a7 commit 3f1fbae

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ CHANGELOG
44
## HEAD (Unreleased)
55
* Add multi-lang component support scaffolding.
66
* Fix type errors in TypeScript checking awsx-classic properties.
7+
* Ensure that FargateService and EC2Service default `continueBeforeSteadyState` to false.
78

89
## 0.40.0 (2022-03-24)
910
* Compatibility with pulumi-aws v5.0.0

awsx/ecr/image.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ export function computeImageFromAsset(
5353
target: dockerInputs.target,
5454
};
5555

56-
pulumi.log.info("dockerBuild: " + JSON.stringify(dockerBuild));
57-
5856
const uniqueImageName = docker.buildAndPushImage(
5957
imageName,
6058
dockerBuild,

awsx/ecs/ec2Service.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ export class EC2Service extends schema.EC2Service {
6060
cluster: aws.ecs.Cluster.isInstance(args.cluster) ? args.cluster.arn : args.cluster,
6161
launchType: "EC2",
6262
loadBalancers: args.loadBalancers ?? taskDefinition?.loadBalancers,
63-
waitForSteadyState: !utils.ifUndefined(args.continueBeforeSteadyState, false),
63+
waitForSteadyState: utils
64+
.ifUndefined(args.continueBeforeSteadyState, false)
65+
.apply((x) => !x),
6466
taskDefinition: taskDefinitionIdentifier,
6567
},
6668
{ parent: this },

awsx/ecs/fargateService.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ export class FargateService extends schema.FargateService {
6464
cluster: aws.ecs.Cluster.isInstance(args.cluster) ? args.cluster.arn : args.cluster,
6565
launchType: "FARGATE",
6666
loadBalancers: args.loadBalancers ?? taskDefinition?.loadBalancers,
67-
waitForSteadyState: !utils.ifUndefined(args.continueBeforeSteadyState, false),
67+
waitForSteadyState: utils
68+
.ifUndefined(args.continueBeforeSteadyState, false)
69+
.apply((x) => !x),
6870
taskDefinition: taskDefinitionIdentifier,
6971
},
7072
{ parent: this },

0 commit comments

Comments
 (0)