make schtasks package windows only

Author: creativeprojects

codecov.yml

@@ -11,6 +11,7 @@ ignore:
   - run_profile.go
   - syslog.go
   - syslog_windows.go
+  - schtasks/permission.go
   - "**/mocks/*.go"
 
 codecov:

schedule/handler.go

@@ -53,7 +53,7 @@ func AddHandlerProvider(provider HandlerProvider) {
 func lookupBinary(name, binary string) error {
 	found, err := exec.LookPath(binary)
 	if err != nil || found == "" {
-		return fmt.Errorf("it doesn't look like %s is installed on your system (cannot find %q in path)", name, binary)
+		return fmt.Errorf("cannot find %q: please ensure %s is installed and available on this system", binary, name)
 	}
 	return nil
 }

schedule/handler_windows.go

@@ -16,9 +16,9 @@ type HandlerWindows struct {
 	config SchedulerConfig
 }
 
-// Init a connection to the task scheduler
+// Init only checks the schtask.exe tool is available
 func (h *HandlerWindows) Init() error {
-	return schtasks.Init()
+	return lookupBinary("schtasks", "schtasks.exe")
 }
 
 // Close does nothing with this implementation

schtasks/actions.go

@@ -1,3 +1,5 @@
+//go:build windows
+
 package schtasks
 
 type Actions struct {

schtasks/config.go

@@ -1,3 +1,5 @@
+//go:build windows
+
 package schtasks
 
 type Config struct {

schtasks/constants.go

@@ -0,0 +1,35 @@
+//go:build windows
+
+package schtasks
+
+const (
+	dateFormat        = "2006-01-02T15:04:05-07:00"
+	maxTriggers       = 60
+	author            = "Author"
+	taskSchema        = "http://schemas.microsoft.com/windows/2004/02/mit/task"
+	taskSchemaVersion = "1.4"
+	defaultPriority   = 8
+	binaryPath        = "schtasks.exe"
+	tasksPathPrefix   = `\resticprofile backup\`
+	// From: https://learn.microsoft.com/en-us/windows/win32/secauthz/security-descriptor-string-format
+	// O:owner_sid
+	// G:group_sid
+	// D:dacl_flags(string_ace1)(string_ace2)... (string_acen)  <---
+	// S:sacl_flags(string_ace1)(string_ace2)... (string_acen)
+	// With flag:
+	// "AI"	SDDL_AUTO_INHERITED
+	// From: https://learn.microsoft.com/en-us/windows/win32/secauthz/ace-strings
+	// - first field:
+	// "A" 	SDDL_ACCESS_ALLOWED
+	// - third field
+	// "FA" 	SDDL_FILE_ALL 	FILE_GENERIC_ALL
+	// "FR" 	SDDL_FILE_READ 	FILE_GENERIC_READ
+	// "FW" 	SDDL_FILE_WRITE 	FILE_GENERIC_WRITE
+	// "FX" 	SDDL_FILE_EXECUTE 	FILE_GENERIC_EXECUTE
+	// From: https://learn.microsoft.com/en-us/windows/win32/secauthz/sid-strings
+	// "AU" 	SDDL_AUTHENTICATED_USERS
+	// "BA" 	SDDL_BUILTIN_ADMINISTRATORS
+	// "LS" 	SDDL_LOCAL_SERVICE
+	// "SY" 	SDDL_LOCAL_SYSTEM
+	securityDescriptor = "D:AI(A;;FA;;;BA)(A;;FA;;;SY)(A;;FRFX;;;LS)(A;;FR;;;AU)"
+)

schtasks/errors.go

@@ -1,3 +1,5 @@
+//go:build windows
+
 package schtasks
 
 import "errors"

schtasks/permission.go

@@ -1,3 +1,5 @@
+//go:build windows
+
 package schtasks
 
 import (

schtasks/principal.go

@@ -1,3 +1,5 @@
+//go:build windows
+
 package schtasks
 
 const serviceAccount = "S-1-5-18"

schtasks/schtasks.go

@@ -1,3 +1,5 @@
+//go:build windows
+
 package schtasks
 
 import (
@@ -11,10 +13,6 @@ import (
 	"strings"
 )
 
-const (
-	binaryPath = "schtasks.exe"
-)
-
 func getRegisteredTasks() ([]string, error) {
 	raw, err := listRegisteredTasks()
 	if err != nil {
@@ -26,7 +24,7 @@ func getRegisteredTasks() ([]string, error) {
 	}
 	list := make([]string, 0)
 	for _, taskLine := range all {
-		if strings.HasPrefix(taskLine[0], tasksPath) {
+		if len(taskLine) > 0 && strings.HasPrefix(taskLine[0], tasksPathPrefix) {
 			list = append(list, taskLine[0])
 		}
 	}
@@ -72,9 +70,14 @@ func createTask(taskName, filename, username, password string) (string, error) {
 		return "", ErrEmptyTaskName
 	}
 	params := []string{"/create", "/tn", taskName, "/xml", filename}
+
+	if len(password) > 0 && len(username) == 0 {
+		return "", errors.New("username is required when specifying a password")
+	}
 	if len(password) > 0 {
 		params = append(params, "/ru", username, "/rp", password)
 	}
+
 	stdout, stderr := &bytes.Buffer{}, &bytes.Buffer{}
 	cmd := exec.Command(binaryPath, params...)
 	cmd.Stdout = stdout