Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop emitter leaving particles behind #169

Open
rohan-deshpande opened this issue Jun 20, 2021 · 3 comments
Open

Stop emitter leaving particles behind #169

rohan-deshpande opened this issue Jun 20, 2021 · 3 comments

Comments

@rohan-deshpande
Copy link
Collaborator

As referenced here #147 stopEmit is stopping particles from living out their natural life span.

Need to play with the isEmitting prop on the emitter. Best course of action would be to set up an experiment in the sandbox to test this out and make sure no existing functionality is broken
@ertugrulcetin
Copy link

Hi @rohan-deshpande any updates on this?

@andrewleek-droplab andrewleek-droplab mentioned this issue Apr 7, 2022
Closed
@andrewleek-droplab
Copy link
Contributor

I have just made a pull-request to resolve this bug. You can find it here: #206

@ertugrulcetin
Copy link

This looks nice, thanks! @andrewleek-droplab - @rohan-deshpande can you merge it please?

@andrewleek-droplab andrewleek-droplab mentioned this issue Apr 15, 2022
Merged
@rohan-deshpande rohan-deshpande mentioned this issue Aug 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rohan-deshpande @ertugrulcetin @andrewleek-droplab