add test for bool default not to overwrite existing value#50
Draft
robbkidd wants to merge 2 commits intocreasty:masterfrom
Draft
add test for bool default not to overwrite existing value#50robbkidd wants to merge 2 commits intocreasty:masterfrom
robbkidd wants to merge 2 commits intocreasty:masterfrom
Conversation
Demonstrates that that a default of true will override an existing value of false for bool fields.
…ble to set to false
robbkidd
commented
Jan 18, 2024
| func TestOverrideDefaultTrueBoolToFalse(t *testing.T) { | ||
| type example struct { | ||
| BoolTrue bool `default:"true"` | ||
| BoolPointerTrue *bool `default:"true"` |
Author
There was a problem hiding this comment.
This is the workaround to have a field that defaults to true that a user can still set to false and not have defaults.Set() change it back to true.
This was referenced Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrates the issue in #49 that that a default of
truewill override an existing value offalsefor bool fields.