Skip to content

Add intl support for windows #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add intl support for windows #756

wants to merge 5 commits into from

Conversation

crazywhalecc
Copy link
Owner

@crazywhalecc crazywhalecc commented Jun 10, 2025

What does this PR do?

ICU is built using vcpkg from static-php-cli-hosted. Since vcpkg integration has not yet been implemented, use solution 1 to temporarily support intl extension. The current implementation is very straightforward.

Closes #435

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php, run composer cs-fix at local machine.
  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added the kind/extension Issues related to extensions label Jun 10, 2025
@crazywhalecc crazywhalecc added the os/windows Things only for Windows label Jun 10, 2025
@henderkes
Copy link
Collaborator

why will this close imagick support?

@crazywhalecc
Copy link
Owner Author

why will this close imagick support?

Sorry, I made a mistake. I just finished doing housework and feel dizzy :P

@henderkes
Copy link
Collaborator

ah, got it

@crazywhalecc
Copy link
Owner Author

/cc @simonhamp

Sorry to bother you, but I don't have a working test case or existing project to test intl extensions on windows. I would be grateful if you could test it and provide feedback.

@binaryfire
Copy link

@crazywhalecc @henderkes This will be a game changer for Laravel + Windows🔥 Thanks for adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/extension Issues related to extensions os/windows Things only for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension request: intl on Windows
3 participants