Skip to content

Fixed memory leak caused by animation, MORE #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Fixed memory leak caused by animation, MORE #57

merged 1 commit into from
Feb 7, 2019

Conversation

olfek
Copy link
Contributor

@olfek olfek commented Sep 3, 2018

Error:
Warning: Can't call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
in Toast (at [REDACTED])
in RCTView (at View.js:43)
in [REDACTED] (at SceneView.js:9)
in SceneView (at StackViewLayout.js:563)
in RCTView (at View.js:43)
in RCTView (at View.js:43)
in RCTView (at View.js:43)
in AnimatedComponent (at StackViewCard.js:12)
in Card (at createPointerEventsContainer.js:28)
in Container (at StackViewLayout.js:612)

Error:
Warning: Can't call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in Toast (at [REDACTED])
    in RCTView (at View.js:43)
    in [REDACTED] (at SceneView.js:9)
    in SceneView (at StackViewLayout.js:563)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in AnimatedComponent (at StackViewCard.js:12)
    in Card (at createPointerEventsContainer.js:28)
    in Container (at StackViewLayout.js:612)
@olfek
Copy link
Contributor Author

olfek commented Sep 4, 2018

@crazycodeboy Hi, could you please take a look at this MR. Thanks.

@olfek
Copy link
Contributor Author

olfek commented Oct 26, 2018

@crazycodeboy Hello, could you please take a look at this MR. Thanks.

@olfek
Copy link
Contributor Author

olfek commented Nov 6, 2018

@crazycodeboy 您好,请您查看此合并请求。它修复了由动画引起的内存泄漏。谢谢。

@olfek
Copy link
Contributor Author

olfek commented Jan 18, 2019

Hello,

It is likely this fork and its changes will be removed very soon for reasons beyond my control, I recommend that you merge these changes at your earliest convenience.

Thank you.

@crazycodeboy crazycodeboy merged commit 84c10f6 into crazycodeboy:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants