Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Format and lint code using Ruff #156

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Chore: Format and lint code using Ruff #156

merged 1 commit into from
Aug 28, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Aug 27, 2024

About

Not invoked yet when conceiving this project, this patch adjusts code formatting, by using the Ruff code formatter. No significant semantic changes have been applied.

@amotl amotl requested review from matriv and surister August 27, 2024 21:49
@amotl amotl marked this pull request as ready for review August 27, 2024 21:49
@amotl amotl force-pushed the amo/support-table-quoting branch 2 times, most recently from fab6f4b to a80fb4d Compare August 28, 2024 06:59
@matriv
Copy link
Contributor

matriv commented Aug 28, 2024

Can I please ask you to remove the quote_relation_name commit from this PR, since it's added with: #155

@amotl amotl changed the base branch from amo/support-table-quoting to main August 28, 2024 07:21
Comment on lines -275 to +283
{ cmd = "mypy" },
# { cmd = "mypy" },
Copy link
Member Author

@amotl amotl Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusting the code base for proper type-hinting did not happen within this patch, because I did not want to mix up concerns too much, by adding those changes within the noise of code-formatting only.

It will be tackled on a subsequent iteration.

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe wait for @surister to also take a look, thx!

@amotl amotl merged commit 473455d into main Aug 28, 2024
27 checks passed
@amotl amotl deleted the amo/format-code branch August 28, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants