Doctrine3: Code-style fixes

Author: amotl

DEVELOP.rst

@@ -93,11 +93,17 @@ Running the Tests
     # Run test suite
     composer run test
 
-    # Run code style checks
-    composer run style
+
+Invoke code style checks
+========================
+
+::
 
     # Run code style checks
-    ./vendor/bin/phpcs ./src
+    composer run check-style
+
+    # Some code style quirks can be automatically fixed
+    composer run fix-style
 
 
 ****************************

composer.json

@@ -43,7 +43,7 @@
     },
     "scripts": {
         "test": "XDEBUG_MODE=coverage phpunit --coverage-clover build/logs/clover.xml",
-        "check-style": "phpcs",
+        "check-style": "phpcs -s",
         "fix-style": "phpcbf"
     }
 }

src/Crate/DBAL/Driver/PDOCrate/PDOConnection.php

@@ -88,5 +88,4 @@ public function exec($sql): int
             throw Exception::new($exception);
         }
     }
-
 }

src/Crate/DBAL/Platforms/CratePlatform.php

@@ -433,6 +433,7 @@ public function getTimeTypeDeclarationSQL(array $fieldDeclaration)
     /**
      * {@inheritDoc}
      */
+    // phpcs:ignore PSR2.Methods.MethodDeclaration.Underscore
     protected function _getCommonIntegerTypeDeclarationSQL(array $columnDef)
     {
         return '';
@@ -671,6 +672,7 @@ public function getCreateTableSQL(Table $table, $createFlags = self::CREATE_INDE
     /**
      * {@inheritDoc}
      */
+    // phpcs:ignore PSR2.Methods.MethodDeclaration.Underscore
     protected function _getCreateTableSQL($name, array $columns, array $options = array())
     {
         $columnListSql = $this->getColumnDeclarationListSQL($columns);

src/Crate/DBAL/Schema/CrateSchemaManager.php

@@ -32,6 +32,7 @@ class CrateSchemaManager extends AbstractSchemaManager
      * {@inheritdoc}
      *
      */
+    // phpcs:ignore PSR2.Methods.MethodDeclaration.Underscore
     protected function _getPortableTableIndexesList($tableIndexes, $tableName = null)
     {
         $buffer = [];
@@ -51,6 +52,7 @@ protected function _getPortableTableIndexesList($tableIndexes, $tableName = null
     /**
      * {@inheritDoc}
      */
+    // phpcs:ignore PSR2.Methods.MethodDeclaration.Underscore
     protected function _getPortableTableColumnDefinition($tableColumn)
     {
         $tableColumn = array_change_key_case($tableColumn, CASE_LOWER);
@@ -83,6 +85,7 @@ protected function _getPortableTableColumnDefinition($tableColumn)
     /**
      * {@inheritDoc}
      */
+    // phpcs:ignore PSR2.Methods.MethodDeclaration.Underscore
     protected function _getPortableTablesList($tables)
     {
         $tableNames = array();