Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back light theme #709

Open
Tracked by #1
amotl opened this issue Feb 19, 2021 · 1 comment
Open
Tracked by #1

Bring back light theme #709

amotl opened this issue Feb 19, 2021 · 1 comment

Comments

@amotl
Copy link
Member

amotl commented Feb 19, 2021

Hi there,

#707 makes the light theme unavailable. However, some people might like it so we might want to bring it back.

We are using the dark theme as a default now, because all the (former) enterprise plugins only implemented that one.

Because the dynamic plugin loading subsystem only supports regular CSS stylesheets, there is no way to align this with SCSS stylesheets used for the general site. However, to see the UI using the light theme, SCSS variable modifiers are used. So, it will need another iteration to refactor those plugins into regular views to make their stylesheets be able to use SCSS.

The switch is in app/styles/styles.scss.

// TODO: Add a switch for selecting light vs. dark theme.
// @import 'vars/light-theme-variables';
@import 'vars/dark-theme-variables';

With kind regards,
Andreas.

@seut
Copy link
Member

seut commented Dec 5, 2022

Can we just remove the light theme unless someone asks for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants