Skip to content

Conversation

@Mr-Sunglasses
Copy link
Contributor

fix: #1366

@Mr-Sunglasses
Copy link
Contributor Author

@epage https://test.pypi.org/project/typos-test-S/ this is the preview of how it looks on PyPI after the changes.

@epage
Copy link
Collaborator

epage commented Aug 28, 2025

Also, I tend to prefer for people to squash review commits, leaving the commits in the PR to represent how the change should be understood, reviewed, and merged

@coveralls
Copy link

coveralls commented Aug 28, 2025

Pull Request Test Coverage Report for Build 17308268900

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 20.434%

Totals Coverage Status
Change from base Build 17305477833: 0.0%
Covered Lines: 574
Relevant Lines: 2809

💛 - Coveralls

@Mr-Sunglasses
Copy link
Contributor Author

Mr-Sunglasses commented Aug 28, 2025

Also, I tend to prefer for people to squash review commits, leaving the commits in the PR to represent how the change should be understood, reviewed, and merged

I squashed the commit into one, after seeing the action check fails, I'll make sure to do it in future PR's also. 🫡

@Mr-Sunglasses
Copy link
Contributor Author

Also, I tend to prefer for people to squash review commits, leaving the commits in the PR to represent how the change should be understood, reviewed, and merged

https://test.pypi.org/project/typos-test-S/ please check this before merging as this is the version of how it looks on pypi after the current changes.

@epage
Copy link
Collaborator

epage commented Aug 29, 2025

As the commit lint check says, it doesn't have to be perfect. If i could have it open threads on the commits that could be resolved by author, I would.

Copy link
Collaborator

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge when I can get a chance to also release it.

@epage epage merged commit ce10367 into crate-ci:master Aug 29, 2025
21 checks passed
"Programming Language :: Python :: Implementation :: PyPy",
]

readme = "../../README.md"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems to cause a failure in the CI: https://github.com/crate-ci/typos/actions/runs/17326100151/job/49190507436

💥 maturin failed
Caused by: Failed to build source distribution
Caused by: Failed to add file from /home/runner/work/typos/typos/crates/typos-cli/../../README.md to sdist as typos-1.35.7/../../README.md
Caused by: paths in archives must not have .. when setting path for typos-1.35.7
Error: The process '/home/runner/work/_temp/390c6546-5ac8-484f-89f5-6673995d040c/maturin' failed with exit code 1
at ExecState._setResult (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1823:25)
at ExecState.CheckComplete (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1806:18)
at ChildProcess. (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1700:27)
at ChildProcess.emit (node:events:524:28)
at maybeClose (node:internal/child_process:1104:16)
at ChildProcess._handle.onexit (node:internal/child_process:304:5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more metadata to pypi for typos.

4 participants