-
Notifications
You must be signed in to change notification settings - Fork 152
feat: Add more metadata about the project for PyPi #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@epage https://test.pypi.org/project/typos-test-S/ this is the preview of how it looks on PyPI after the changes. |
|
Also, I tend to prefer for people to squash review commits, leaving the commits in the PR to represent how the change should be understood, reviewed, and merged |
Pull Request Test Coverage Report for Build 17308268900Details
💛 - Coveralls |
040ef59 to
2e5763f
Compare
I squashed the commit into one, after seeing the action check fails, I'll make sure to do it in future PR's also. 🫡 |
9c4dce5 to
e2419ab
Compare
https://test.pypi.org/project/typos-test-S/ please check this before merging as this is the version of how it looks on pypi after the current changes. |
|
As the commit lint check says, it doesn't have to be perfect. If i could have it open threads on the commits that could be resolved by author, I would. |
epage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge when I can get a chance to also release it.
| "Programming Language :: Python :: Implementation :: PyPy", | ||
| ] | ||
|
|
||
| readme = "../../README.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line seems to cause a failure in the CI: https://github.com/crate-ci/typos/actions/runs/17326100151/job/49190507436
💥 maturin failed
Caused by: Failed to build source distribution
Caused by: Failed to add file from /home/runner/work/typos/typos/crates/typos-cli/../../README.md to sdist as typos-1.35.7/../../README.md
Caused by: paths in archives must not have..when setting path for typos-1.35.7
Error: The process '/home/runner/work/_temp/390c6546-5ac8-484f-89f5-6673995d040c/maturin' failed with exit code 1
at ExecState._setResult (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1823:25)
at ExecState.CheckComplete (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1806:18)
at ChildProcess. (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1700:27)
at ChildProcess.emit (node:events:524:28)
at maybeClose (node:internal/child_process:1104:16)
at ChildProcess._handle.onexit (node:internal/child_process:304:5)
fix: #1366