Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a space #671

Open
max-sixty opened this issue Apr 29, 2023 · 1 comment
Open

Adds a space #671

max-sixty opened this issue Apr 29, 2023 · 1 comment
Labels
bug Not as expected good first issue Help wanted!

Comments

@max-sixty
Copy link
Contributor

The most minor issue ever, but adding since hopefully helpful on net.

Bumping releases adds a space after the version number:

diff --git a/prql-compiler/prqlc/Cargo.toml b/prql-compiler/prqlc/Cargo.toml
index a02a8ff1..079471ca 100644
--- a/prql-compiler/prqlc/Cargo.toml
+++ b/prql-compiler/prqlc/Cargo.toml
@@ -20,7 +20,7 @@ concolor-clap = {version = "0.1.0", features = ["api"]}
 env_logger = {version = "0.10.0", features = ["color"]}
 itertools = "0.10.3"
 notify = "^5.1.0"
-prql-compiler = {path = '..', version = "0.8.0"}
+prql-compiler = {path = '..', version = "0.8.1" }
 regex = {version = "1.8.1", features = ["std", "unicode"]}
 serde = "^1"
 serde_json = "1.0.81"
@epage epage added the bug Not as expected label Apr 30, 2023
@epage
Copy link
Collaborator

epage commented Apr 30, 2023

Thanks for reporting this!

Yes, we are overwriting not just the value bit the "decor" which we instead need to preserve. There are likely other cases where we mess this up, like setting package.version and setting workspace.package.version

@epage epage added the good first issue Help wanted! label Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not as expected good first issue Help wanted!
Projects
None yet
Development

No branches or pull requests

2 participants