Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resize #12

Closed
alvirtuoso opened this issue May 16, 2017 · 8 comments
Closed

Unable to resize #12

alvirtuoso opened this issue May 16, 2017 · 8 comments

Comments

@alvirtuoso
Copy link

alvirtuoso commented May 16, 2017

screen shot 2017-05-16 at 2 39 06 pm

Here's my markup:
<star-rating :rating="3.8" :star-size="30" :read-only="true" :increment="0.01"></star-rating>

@smccumsey
Copy link

Seeing same issue. Works when I wrap it in spans (idk why) though.

<span><star-rating :star-size="30" :show-rating="false" :rating="4" :inline="true" :active-color="`darkgrey`" ></star-rating></span>

@craigh411
Copy link
Owner

craigh411 commented May 17, 2017

I can't seem to reproduce this. What browser is this appearing in? Also, do you have any styles that might be overriding the .star-rating, .star classes, something like this JSFiddle gets close to what you are seeing. If this is the case I will consider changing the class names inside the component so it's not so easy to accidentally override them.

@smccumsey
Copy link

I have Google Chrome Version 58.0.3029.110 (64-bit)

And for the js fiddle I'm not sure if this is what you meant but when I added the class "container__stars" to star-rating component then changed '.star-rating' to '.container__stars' in the CSS the stars were still cut off.

@craigh411
Copy link
Owner

craigh411 commented May 17, 2017

@smccumsey Do you still see cut off stars in this JSFiddle without any css?

@smccumsey
Copy link

w/o the css the stars aren't cut off

@craigh411
Copy link
Owner

craigh411 commented May 17, 2017

Ah, OK, then this may just be a case of making the overflow visible on the stars. Thanks for your quick responses, they are really appreciated.

@alvirtuoso
Copy link
Author

@craigh411 Tested with empty .star-rating css and all is fine. Thanks for this component, btw!

@craigh411
Copy link
Owner

OK, I've now changed the internal class names so it shouldn't be so easy to unintentionally override the default styles. See the release notes for version 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants