Skip to content

Commit 6ebfca2

Browse files
committed
Just ignore "script-on" tree-construction tests instead of "skipping"
Calling them "skipped" implies that they're known but unintentional failure cases, but really they're just not applicable at all to a non-scripted parser. This reduces the total number of skipped tests by 8: Ran 1673 tests in 0.15s Passed: 1673 Failed: 0 Skipped: 16
1 parent 0f2deb0 commit 6ebfca2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/tree-construction.lua

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,10 @@ do
149149
local tests = parseTestData(filename)
150150
for i, test in ipairs(tests) do
151151
local input = assert(test.data)
152-
if
153-
test["script-on"]
154-
or input:find("<menuitem>")
155-
then
152+
if test["script-on"] then
153+
-- The "script-on" tests are not relevant to a non-scripted
154+
-- parser, so they are just ignored instead of "skipped".
155+
elseif input:find("<menuitem>") then
156156
skipped = skipped + 1
157157
else
158158
local expected = assert(test.document)

0 commit comments

Comments
 (0)