-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 Refactor #5
2.0 Refactor #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments and the CI needs to pass. Otherwise we are getting really close! 💯 work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonmccallister Replied to the last 2 comments, in your court.
CI pipeline is passing now as well.
LGTM! |
Enough has changed here, that this would have to be
2.0
.Here's a summary:
AWS_REGION
is now automatically used if presentkeyPrefix
has been replaced withformatKey
, which will allow more flexibility and is compatible with compound keysttl
is now possible viattlAttribute
andttl
.consistentRead
is exposed an option (lifted from https://github.com/aws/aws-sdk-php/blob/3d0d24d9dad824ea4344cfc711b9989d92070aac/src/DynamoDb/StandardSessionConnection.php#L9)partitionKeyAttribute
/sortKeyAttribute
.deleteMany
/deleteExpired
(Scan/batch).deleteExpired
really shouldn't ever need to be used, as you should use Dynamo's TTL setting.DynamoDbSession->allowGc
defaults tofalse
.Sesssion::timeout
/ini session settings.Note: this branch is what is currently running on demos via
dev-cloud-refactor