vpkpp: HOG and VPP should not be case-sensitive, and clean up VPP a bit

Author: craftablescience

include/vpkpp/format/HOG.h

@@ -18,10 +18,6 @@ class HOG : public PackFileReadOnly {
 		return HOG::GUID;
 	}
 
-	[[nodiscard]] constexpr bool isCaseSensitive() const override {
-		return true;
-	}
-
 	[[nodiscard]] std::optional<std::vector<std::byte>> readEntry(const std::string& path_) const override;
 
 	[[nodiscard]] Attribute getSupportedEntryAttributes() const override;

include/vpkpp/format/VPP.h

@@ -20,10 +20,6 @@ class VPP : public PackFileReadOnly {
 		return VPP::GUID;
 	}
 
-	[[nodiscard]] constexpr bool isCaseSensitive() const override {
-		return true;
-	}
-
 	[[nodiscard]] std::optional<std::vector<std::byte>> readEntry(const std::string& path_) const override;
 
 	[[nodiscard]] Attribute getSupportedEntryAttributes() const override;

src/vpkpp/format/VPP.cpp

@@ -38,13 +38,11 @@ std::unique_ptr<PackFile> VPP::open(const std::string& path, const EntryCallback
 		}
 
 		// Get file table offset
-		// 16 is the byte size of the header
-		uint32_t headerSize = 16;
+		static constexpr uint32_t headerSize = sizeof(uint32_t) * 4;
 		reader.seek_in(headerSize + sourcepp::math::paddingForAlignment(VPP_ALIGNMENT, headerSize));
 
 		// Get first file offset
-		// 64 is the byte size of each file directory entry
-		uint32_t fileTableSize = 64 * entryCount;
+		const uint32_t fileTableSize = (60 + sizeof(uint32_t)) * entryCount;
 		uint32_t entryOffset = reader.tell_in() + fileTableSize + sourcepp::math::paddingForAlignment(VPP_ALIGNMENT, fileTableSize);
 
 		// Read file entries
@@ -78,13 +76,11 @@ std::unique_ptr<PackFile> VPP::open(const std::string& path, const EntryCallback
 		}
 
 		// Get file table offset
-		// 16 is the byte size of the header
-		uint32_t headerSize = 16;
+		static constexpr uint32_t headerSize = sizeof(uint32_t) * 4;
 		reader.seek_in(headerSize + sourcepp::math::paddingForAlignment(VPP_ALIGNMENT, headerSize));
 
 		// Get first file offset
-		// 32 is the byte size of each file directory entry
-		uint32_t fileTableSize = 32 * entryCount;
+		const uint32_t fileTableSize = (24 + sizeof(uint32_t) * 2) * entryCount;
 		uint32_t entryOffset = reader.tell_in() + fileTableSize + sourcepp::math::paddingForAlignment(VPP_ALIGNMENT, fileTableSize);
 
 		// Read file entries