Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9658 Pull requests #78

Open
withanage opened this issue Oct 28, 2024 · 5 comments
Open

9658 Pull requests #78

withanage opened this issue Oct 28, 2024 · 5 comments
Assignees

Comments

@withanage
Copy link
Contributor

withanage commented Oct 28, 2024

Here are the list of PRS

User invitatiion workflow for OJS

No. PR Description PR Dependency Reviewer Core Status
1 pkp/pkp-lib#10551 userRoleAssignment adjustments no 🟢 Merged
2 pkp/pkp-lib#10557 Search-API support future users no ✔️
3 pkp/pkp-lib#10563 Add enduser role endpoint no 🟢 merged
4 pkp/ojs#4497 OJS specific invitation locale no 🟢 Merged
5 pkp/ojs#4494 Cypress iframe support no 🟢 Merged
6 pkp/pkp-lib#10558 Invitation integration PHP Erik ✔️ 🟢 merged
7 pkp/pkp-lib#10566 Cypress tests for user invitation ✔️ 🟢 merged
8 pkp/ui-library#439 Minor fixes no Jarda 🟢 merged
9 pkp/ui-library#382 Invitation table - UI Jarda ✔️ 🟢 Merged
10 pkp/ui-library#441 Remove role Jarda ✔️ 🟢 Merged
11 pkp/pkp-lib#10585 validation Dimitris 🟢 Merged
12 pkp/ojs#4504 Locale changes 🟡 Wait until Boah finishes manual testing
13 pkp/pkp-lib#10588 Invitation cancel popups Local changes Jarda 🟡 Ready to review

Redesigned Users table for OJS

No. PR Description PR Dependency Reviewer Core Status
14 pkp/ui-library#437 UsersTable ⏱️ Depends that user invitation gets merged Jarda ✔️ 🟡 Ready to review
15 pkp/pkp-lib#10576 new Deisgn - PHP ⏱️ Depends that user invitation and 10 gets merged ✔️ 🟡 Ready to review

Related OMP and OPS

No. PR Description PR Dependency Reviewer Core Status
1 pkp/ops#805 OPS Add cypress iframe support Similar to pkp/ojs#4494 ✔️ 🟢
2 pkp/omp#1750 OMP Add cypress iframe support Similar to pkp/ojs#4494 ✔️ 🟢
@withanage withanage self-assigned this Oct 28, 2024
@withanage withanage changed the title PR merge Pull requests Oct 28, 2024
@withanage
Copy link
Contributor Author

withanage commented Oct 30, 2024

@ipula here is the list missing pieces.

@asmecher
Copy link

asmecher commented Nov 1, 2024

Hi @withanage -- I reviewed and merged pkp/ojs#4494. I didn't update the table at the top; it looks like several other PRs have been merged there too.

@withanage
Copy link
Contributor Author

Thannks @asmecher , as soon as pkp/pkp-lib#10563 gets merged, I will do some final integrated testings and merge the new cypress tests , pkp/pkp-lib#10566

@ewhanson
Copy link

ewhanson commented Nov 1, 2024

@withanage, I reviewed and merged pkp/ui-library#439 as well. Just waiting on a review for pkp/pkp-lib#10563.

@withanage
Copy link
Contributor Author

Thanks a lot @ewhanson ! Updated the list

@withanage withanage changed the title Pull requests 9658 Pull requests Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants