Renamed domain_to_unicode to domain_to_u8 (#121)

Author: glynos

README.md

@@ -137,7 +137,7 @@ int main() {
   std::cout << "Domain?   " << std::boolalpha << url.is_domain() << std::endl;
   std::cout << "Domain:   " << url.hostname() << std::endl;
   std::cout << "Domain:   "
-            << skyr::domain_to_unicode(url.hostname()).value() << std::endl;
+            << skyr::domain_to_u8(url.hostname()).value() << std::endl;
 
   std::cout << "Port:     " << url.port<std::uint16_t>().value() << std::endl;
 

docs/index.rst

@@ -59,12 +59,14 @@ and standard library.
 
        std::cout << "Domain?   " << std::boolalpha << url.is_domain() << std::endl;
        std::cout << "Domain:   " << url.hostname() << std::endl;
-
-       std::cout << "Pathname: " <<
-           skyr::percent_decode<std::string>(url.pathname()).value() << std::endl;
+       std::cout << "Domain:   "
+                 << skyr::domain_to_u8(url.hostname()).value() << std::endl;
 
        std::cout << "Port:     " << url.port<std::uint16_t>().value() << std::endl;
 
+       std::cout << "Pathname: "
+                 << skyr::percent_decode<std::string>(url.pathname()).value() << std::endl;
+
        std::cout << "Search parameters" << std::endl;
        const auto &search = url.search_parameters();
        for (const auto &[key, value] : search) {

include/skyr/v1/domain/domain.hpp

@@ -62,7 +62,7 @@ inline auto domain_to_ascii(std::string_view domain) {
 ///
 /// \param ascii A Punycode encoded domain
 /// \returns A valid UTF-8 encoded domain, or an error
-auto domain_to_unicode(std::string_view ascii) -> tl::expected<std::string, domain_errc>;
+auto domain_to_u8(std::string_view ascii) -> tl::expected<std::string, domain_errc>;
 }  // namespace v1
 }  // namespace skyr
 

src/v1/domain/domain.cpp

@@ -159,7 +159,7 @@ auto domain_to_ascii(
   return domain_to_ascii(utf32.value(), be_strict, validation_error);
 }
 
-auto domain_to_unicode(std::string_view ascii) -> tl::expected<std::string, domain_errc> {
+auto domain_to_u8(std::string_view ascii) -> tl::expected<std::string, domain_errc> {
   auto labels = std::vector<std::string>{};
   for (auto label : split(ascii, ".")) {
     if (label.substr(0, 4) == "xn--") {

src/v1/url/url.cpp

@@ -176,7 +176,7 @@ auto url::ipv6_address() const -> std::optional<skyr::ipv6_address> {
 }
 
 [[nodiscard]] auto url::domain() const -> std::optional<string_type> {
-  return is_domain()? std::make_optional(skyr::domain_to_unicode(hostname()).value()) : std::nullopt;
+  return is_domain()? std::make_optional(skyr::domain_to_u8(hostname()).value()) : std::nullopt;
 }
 
 auto url::set_port(string_view port) -> std::error_code {

tests/domain/domain_tests.cpp

@@ -43,7 +43,7 @@ TEST_CASE("valid domains from ascii", "[domain]") {
 
   SECTION("ascii_to_domain_tests") {
     const auto &[expected, input] = domain;
-    auto instance = skyr::domain_to_unicode(input);
+    auto instance = skyr::domain_to_u8(input);
     REQUIRE(instance);
     CHECK(expected == instance.value());
   }