Skip to content

Commit 2c94e51

Browse files
committed
Update clang-tidy configuration
1 parent dfc3f7c commit 2c94e51

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

.clang-tidy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ CheckOptions:
5151
value: lower_case
5252
- key: readability-identifier-naming.MemberCase
5353
value: lower_case
54+
- key: readability-identifier-naming.PrivateMemberSuffix
55+
value: '_'
5456
- key: readability-identifier-naming.ParameterCase
5557
value: lower_case
5658
- key: readability-identifier-naming.VariableCase

.github/workflows/clang-tidy.yml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,13 @@ jobs:
2727
export LDFLAGS="-stdlib=libc++ -lc++abi"
2828
./vcpkg install uni-algo nlohmann-json
2929
30+
- name: Install Catch2
31+
run: |
32+
cd ${GITHUB_WORKSPACE}/vcpkg
33+
export CXXFLAGS="-stdlib=libc++"
34+
export LDFLAGS="-stdlib=libc++ -lc++abi"
35+
./vcpkg install catch2
36+
3037
- name: Configure CMake
3138
run: |
3239
cmake \
@@ -35,18 +42,13 @@ jobs:
3542
-DCMAKE_CXX_STANDARD=23 \
3643
-DCMAKE_BUILD_TYPE=Debug \
3744
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
38-
-Dskyr_BUILD_TESTS=OFF \
45+
-Dskyr_BUILD_TESTS=ON \
3946
-Dskyr_BUILD_DOCS=OFF \
4047
-Dskyr_BUILD_EXAMPLES=OFF \
4148
-Dskyr_BUILD_WITH_LLVM_LIBCXX=ON \
4249
-DCMAKE_TOOLCHAIN_FILE=${GITHUB_WORKSPACE}/vcpkg/scripts/buildsystems/vcpkg.cmake
4350
44-
- name: Run clang-tidy on headers
45-
run: |
46-
find include -name '*.hpp' -print0 | \
47-
xargs -0 -n1 -P$(nproc) clang-tidy-18 -p build --warnings-as-errors='*'
48-
49-
- name: Run clang-tidy on tests
51+
- name: Run clang-tidy on source files
5052
run: |
5153
find tests -name '*.cpp' -print0 | \
5254
xargs -0 -n1 -P$(nproc) clang-tidy-18 -p build --warnings-as-errors='*'

0 commit comments

Comments
 (0)