Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Enhancements subject / group level GLM and results #443

Merged
merged 7 commits into from
Dec 21, 2021
Merged

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Dec 21, 2021

  • when in MNI space unless a mask is provided in the stats model, the default mask will be the SPM ICV mask
  • allow to specify the threshold for inclusive masking in the GLM (if users don't want to tweak the spm_my_defaults)
  • fix several bugs and refactor code for group level GLM and results
  • skip contrast creation when a required condition in it is missing
  • skip results computation when a contrast is missing
  • possibility to cap the max number of volumes to include in a run (in case some runs were not stopped in time)
  • allow for better multitask support

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #443 (aef56ea) into dev (7e68bb3) will decrease coverage by 0.46%.
The diff coverage is 35.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #443      +/-   ##
==========================================
- Coverage   69.72%   69.25%   -0.47%     
==========================================
  Files         153      157       +4     
  Lines        3032     3100      +68     
==========================================
+ Hits         2114     2147      +33     
- Misses        918      953      +35     
Flag Coverage Δ
unittests 69.25% <35.50%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batches/setBatchEstimateModel.m 56.25% <0.00%> (ø)
src/batches/setBatchGroupLevelContrasts.m 0.00% <0.00%> (ø)
src/batches/setBatchGroupLevelResults.m 0.00% <0.00%> (ø)
src/batches/setBatchResults.m 100.00% <ø> (ø)
src/bids_model/createEmptyModel.m 100.00% <ø> (ø)
src/utils/regexify.m 100.00% <ø> (ø)
src/utils/validationInputFile.m 70.58% <ø> (ø)
src/workflows/bidsCreateROI.m 0.00% <0.00%> (ø)
src/workflows/bidsFFX.m 69.76% <ø> (ø)
src/workflows/bidsRFX.m 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d84cb6b...aef56ea. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant