Skip to content

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Nov 3, 2021

fixes #216

  • add plot events functions
  • add efficiency computation and plotting function
  • add bids model query functions
  • update infra (miss hit), doc, and lint (bash linting)
  • add tests
  • make sure tests pass
  • refactor

For reviewers:

  • can you use the code on your own experiments data?
  • can you easily create code to explore some designs quickly?

@Remi-Gau Remi-Gau marked this pull request as ready for review November 3, 2021 11:03
@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Nov 3, 2021

Example output:

untitledp

untitled

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #428 (9d2dd4a) into dev (3fce4b9) will increase coverage by 1.31%.
The diff coverage is 68.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #428      +/-   ##
==========================================
+ Coverage   69.10%   70.42%   +1.31%     
==========================================
  Files         133      144      +11     
  Lines        2622     2779     +157     
==========================================
+ Hits         1812     1957     +145     
- Misses        810      822      +12     
Impacted Files Coverage Δ
src/QA/anatomicalQA.m 0.00% <0.00%> (ø)
src/QA/functionalQA.m 0.00% <0.00%> (ø)
src/subject_level/specifyContrasts.m 92.85% <ø> (ø)
src/utils/renameSegmentParameter.m 0.00% <0.00%> (ø)
src/utils/renameUnwarpParameter.m 0.00% <0.00%> (ø)
src/workflows/bidsCreateROI.m 0.00% <0.00%> (ø)
src/workflows/bidsRFX.m 0.00% <0.00%> (ø)
src/workflows/bidsResliceTpmToFunc.m 0.00% <0.00%> (ø)
src/workflows/bidsResults.m 43.47% <0.00%> (+0.92%) ⬆️
src/workflows/bidsRoiBasedGLM.m 0.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50b2aa...9d2dd4a. Read the comment docs.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Nov 4, 2021

@marcobarilari @CerenB @iqrashahzad14

The tests pass.

This is ready for alpha testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant