Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add QA for GLM #1135

Merged
merged 17 commits into from
Sep 17, 2023
Merged

[ENH] add QA for GLM #1135

merged 17 commits into from
Sep 17, 2023

Conversation

Remi-Gau
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #1135 (5d87176) into main (f53979a) will decrease coverage by 41.15%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1135       +/-   ##
===========================================
- Coverage   79.57%   38.43%   -41.15%     
===========================================
  Files         285        4      -281     
  Lines        7742      255     -7487     
  Branches       40       40               
===========================================
- Hits         6161       98     -6063     
+ Misses       1565      141     -1424     
  Partials       16       16               
Flag Coverage Δ
cli 38.43% <100.00%> (-0.57%) ⬇️
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave ?
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/parsers.py 90.19% <100.00%> (+1.10%) ⬆️

... and 281 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Sep 17, 2023

Octave failure with goodness of fit module:

https://github.com/cpp-lln-lab/bidspm/actions/runs/6211174458/job/16860114374#step:18:851

warning: Unable to open display.
warning: called from
    spm at line 656 column 9
    spm at line 577 column 4
    spm at line 610 column 5
    MA_inspect_GoF at line 572 column 8
    MA_inspect_GoF at line 687 column 5
    spm_XYZreg at line 513 column 5
    spm_XYZreg at line 562 column 1
    MA_inspect_GoF at line 355 column 5
    MA_inspect_GoF at line 196 column 10
    run_module at line 66 column 1
    cfg_run_cm at line 26 column 5
    local_runcj at line 1717 column 20
    cfg_util at line 972 column 27
    fill_run_job at line 469 column 5
    spm_jobman at line 247 column 13
    saveAndRunWorkflow at line 41 column 14
    bidsFFX at line 128 column 12
    cliStats>runEstimate at line 110 column 7
    cliStats at line 82 column 9
    bidspm>executeAction at line 86 column 7
    bidspm at line 26 column 16
    moae_fmriprep at line 108 column 1
    run at line 93 column 5
    system_tests_fmriprep at line 12 column 1
    run at line 93 column 5
                                                               
warning: Invalid registry handle
warning: called from
    spm_XYZreg at line 578 column 21
    register at line 757 column 5
    spm_orthviews at line 422 column 9
    spm_sections at line 38 column 20
    MA_inspect_GoF at line 201 column 5
    run_module at line 66 column 1
    cfg_run_cm at line 26 column 5
    local_runcj at line 1717 column 20
    cfg_util at line 972 column 27
    fill_run_job at line 469 column 5
    spm_jobman at line 247 column 13
    saveAndRunWorkflow at line 41 column 14
    bidsFFX at line 128 column 12
    cliStats>runEstimate at line 110 column 7
    cliStats at line 82 column 9
    bidspm>executeAction at line 86 column 7
    bidspm at line 26 column 16
    moae_fmriprep at line 108 column 1
    run at line 93 column 5
    system_tests_fmriprep at line 12 column 1
    run at line 93 column 5

17-Sep-2023 03:10:12 - Failed  'MA: inspect goodness of fit'
Invalid object handle
In file "/home/runner/work/bidspm/bidspm/spm12/spm_XYZreg.m" (v7388), function "spm_XYZreg" at line 453.
In file "/home/runner/work/bidspm/bidspm/spm12/spm_orthviews.m" (v7376), function "register" at line 761.
In file "/home/runner/work/bidspm/bidspm/spm12/spm_orthviews.m" (v7376), function "spm_orthviews" at line 422.
In file "/home/runner/work/bidspm/bidspm/spm12/spm_sections.m" (v4199), function "spm_sections" at line 38.
In file "/home/runner/work/bidspm/bidspm/spm12/toolbox/MACS/MA_inspect_GoF.m" (???), function "MA_inspect_GoF" at line 201.
In file "/home/runner/work/bidspm/bidspm/spm12/toolbox/MACS/batch_MA_inspect_GoF.m" (???), function "run_module" at line 66.

@Remi-Gau Remi-Gau marked this pull request as ready for review September 17, 2023 17:13
@Remi-Gau Remi-Gau merged commit 9c649e1 into cpp-lln-lab:main Sep 17, 2023
22 of 26 checks passed
@Remi-Gau Remi-Gau deleted the glm_qa branch September 17, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add MACS goodness of fit after GLM estimation
1 participant