Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] exclude late events #1060

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

Remi-Gau
Copy link
Contributor

fixes #1059

@Remi-Gau Remi-Gau marked this pull request as ready for review June 19, 2023 19:21
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.58%. Comparing base (ae7fa4b) to head (74be277).
Report is 179 commits behind head on main.

Files with missing lines Patch % Lines
src/batches/stats/setBatchSubjectLevelGLMSpec.m 70.83% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
- Coverage   79.60%   79.58%   -0.02%     
==========================================
  Files         246      246              
  Lines        6703     6727      +24     
  Branches       40       40              
==========================================
+ Hits         5336     5354      +18     
- Misses       1351     1357       +6     
  Partials       16       16              
Flag Coverage Δ
cli 38.99% <ø> (ø)
macos-latest_matlab-R2022b 80.82% <78.12%> (-0.03%) ⬇️
octave 76.68% <75.00%> (-0.04%) ⬇️
ubuntu-latest_matlab-R2022b 80.99% <78.12%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 156844b into cpp-lln-lab:main Jun 19, 2023
@Remi-Gau Remi-Gau deleted the exclude_late_events branch June 19, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not include events that happen after the end of a run
1 participant