Skip to content

Commit 5399249

Browse files
authored
Merge pull request #28 from cpp-lln-lab/dev
[REL] 0.2.0
2 parents 09e55cb + 8a77a60 commit 5399249

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+670
-653
lines changed

.github/release-drafter.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
template: |
2+
## Release Notes
3+
4+
## CHANGES
5+
$CHANGES

.github/workflows/miss_hit_quality.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ name: miss_hit_quality
33
on:
44
push:
55
branches:
6+
- main
67
- master
8+
- dev
79
pull_request:
810
branches: ['*']
911

@@ -14,7 +16,8 @@ jobs:
1416

1517
steps:
1618

17-
- uses: actions/checkout@v2
19+
- name: Install CPP_ROI
20+
uses: actions/checkout@v3
1821
with:
1922
submodules: true
2023
fetch-depth: 1
@@ -28,8 +31,6 @@ jobs:
2831
run: |
2932
python -m pip install --upgrade pip setuptools
3033
pip3 install -r requirements.txt
31-
cd tests
32-
make data
3334
3435
- name: MISS_HIT Metrics
3536
run: |

.github/workflows/miss_hit_style.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@ name: miss_hit_style
33
on:
44
push:
55
branches:
6+
- main
67
- master
8+
- dev
79
pull_request:
8-
branches: '*'
10+
branches: ['*']
911

1012
jobs:
1113
build:
@@ -14,7 +16,8 @@ jobs:
1416

1517
steps:
1618

17-
- uses: actions/checkout@v2
19+
- name: Install CPP_ROI
20+
uses: actions/checkout@v3
1821
with:
1922
submodules: true
2023
fetch-depth: 1
@@ -28,8 +31,6 @@ jobs:
2831
run: |
2932
python -m pip install --upgrade pip setuptools
3033
pip3 install -r requirements.txt
31-
cd tests
32-
make data
3334
3435
- name: MISS_HIT Code style
3536
run: |

.github/workflows/run_tests.yml

Lines changed: 0 additions & 78 deletions
This file was deleted.
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
name: tests and coverage with matlab
2+
3+
on:
4+
push:
5+
branches:
6+
- dev
7+
- main
8+
- master
9+
pull_request:
10+
branches: ['*']
11+
schedule:
12+
- cron: "1 1 1 * *"
13+
14+
# Allows you to run this workflow manually from the Actions tab
15+
workflow_dispatch:
16+
17+
jobs:
18+
build:
19+
runs-on: ubuntu-20.04
20+
21+
steps:
22+
- name: Install MATLAB
23+
uses: matlab-actions/setup-matlab@v1.0.1
24+
with:
25+
# MATLAB release to set up R2020a
26+
release: R2020a
27+
28+
- name: Install CPP_ROI
29+
uses: actions/checkout@v3
30+
with:
31+
submodules: true
32+
fetch-depth: 1
33+
34+
- name: Install SPM
35+
run: |
36+
git clone https://github.com/spm/spm12.git --depth 1
37+
38+
- name: Install Moxunit and MOcov
39+
run: |
40+
git clone https://github.com/MOxUnit/MOxUnit.git --depth 1
41+
git clone https://github.com/MOcov/MOcov.git --depth 1
42+
43+
- name: Add bids-matlab
44+
run: |
45+
git clone https://github.com/bids-standard/bids-matlab.git --depth 1
46+
47+
- name: Run commands
48+
uses: matlab-actions/run-command@v1.0.1
49+
with:
50+
command: cd(fullfile(getenv('GITHUB_WORKSPACE'), '.github', 'workflows')); run tests_matlab;
51+
52+
- name: Run tests
53+
run: |
54+
cat test_report.log | grep 0
55+
bash <(curl -s https://codecov.io/bash)
56+
57+
- name: Code coverage
58+
uses: codecov/codecov-action@v1
59+
with:
60+
file: coverage.xml # optional
61+
flags: unittests # optional
62+
name: codecov-umbrella # optional
63+
fail_ci_if_error: true # optional (default = false)

.github/workflows/tests_matlab.m

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
%
2+
% (C) Copyright 2022 CPP ROI developers
3+
4+
root_dir = getenv('GITHUB_WORKSPACE');
5+
6+
addpath(fullfile(root_dir, 'spm12'));
7+
addpath(fullfile(root_dir, 'bids-matlab'));
8+
addpath(fullfile(root_dir, 'MOcov', 'MOcov'));
9+
10+
cd(fullfile(root_dir, 'MOxUnit', 'MOxUnit'));
11+
run moxunit_set_path();
12+
13+
cd(fullfile(root_dir));
14+
15+
initCppRoi();
16+
17+
run run_tests();

.gitignore

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
21
.DS_Store
32

43
*.nii
5-
4+
*.xml
5+
*.log
66
*.asv
77
*.m~
88
*.mat
99

10-
<<<<<<< HEAD
10+
*.html
11+
1112
# files in the demo folder related to running the demo analysis
1213
# demos/roi
13-
=======
14+
1415
atlas/visual_topography_probability_atlas/
15-
>>>>>>> 4a2a3830905dfad9b61804bf99e2941a49e4e2fa
1616

1717
# test folder and dummy data
1818

@@ -28,3 +28,5 @@ envs/*
2828
demos/*/*.json
2929
demos/*/*/*.json
3030
demos/*/derivatives
31+
32+
atlas/*.json

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ repos:
2828
additional_dependencies: [miss_hit]
2929

3030
- repo: https://github.com/pre-commit/pre-commit-hooks
31-
rev: v4.0.1
31+
rev: v4.1.0
3232
hooks:
3333
- id: trailing-whitespace
3434
- id: end-of-file-fixer

README.md

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
1-
<!-- lint disable -->
2-
3-
**Documentation**
4-
5-
**Code quality and style**
6-
7-
**Unit tests and coverage**
8-
9-
**How to cite**
10-
11-
**Contributors**
12-
131
# CPP ROI
142

15-
## :warning: :warning: :warning:
3+
---
4+
5+
## :warning:
166

17-
**This code is fairly unstable (:boom:) and might still change a lot.**
7+
**This code is fairly unstable and might still change.**
188

19-
Also this code currently has 0% test coverage...
9+
So make sure you "pin" which version or commit you are using for a given
10+
project, if you don't want your code to break in the future.
2011

2112
---
2213

@@ -57,8 +48,7 @@ as a submodule, and intitialized when running `initCppSpm`.
5748

5849
### Dependencies
5950

60-
=======
61-
TODO
51+
======= TODO
6252

6353
| Dependencies | Used version |
6454
| ---------------------------------------------------------- | ------------ |
@@ -98,8 +88,4 @@ TODO
9888
Also includes:
9989

10090
- Yeo's 7 networks "atlas"
101-
- add REF and URL
102-
103-
## Contributing
104-
105-
## Contributors
91+
<!-- add REF and URL -->

src/atlas/returnAtlasDir.m renamed to atlas/returnAtlasDir.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
%
1111
% (C) Copyright 2021 CPP ROI developers
1212

13-
atlasDir = fullfile(fileparts(mfilename('fullpath')), '..', '..', 'atlas');
13+
atlasDir = fileparts(mfilename('fullpath'));
1414

1515
if nargin > 0
1616

0 commit comments

Comments
 (0)