Skip to content

Commit 7a2b7db

Browse files
authored
minor updates to docs (#99)
- fix typo in permissions.rst code snippets - declare minimum version for new `--jobs `arg - resolve undefined reference to `HTTPError`
1 parent 1771c64 commit 7a2b7db

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

cpp_linter/cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,8 @@ def _parse_jobs(val: str) -> Optional[int]:
325325
default=1,
326326
type=_parse_jobs,
327327
help="""Set the number of jobs to run simultaneously.
328-
If set to <= 0, the number of jobs will be set to the
329-
number of all available CPU cores.
328+
If set less than or equal to 0, the number of jobs will
329+
be set to the number of all available CPU cores.
330330
331331
Defaults to ``%(default)s``.""",
332332
)

cpp_linter/rest_api/__init__.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ def api_request(
3535
:param data: The HTTP request payload data.
3636
:param headers: The HTTP request headers to use. This can be used to override
3737
the default headers used.
38-
:param strict: If this is set `True`, then an `HTTPError` will be raised when
39-
the HTTP request responds with a status code greater than or equal to 400.
38+
:param strict: If this is set `True`, then an :py:class:`~requests.HTTPError`
39+
will be raised when the HTTP request responds with a status code greater
40+
than or equal to 400.
4041
4142
:returns:
4243
The HTTP request's response object.

docs/conf.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ def run(self):
181181
class CliBadgeVersion(CliBadge):
182182
badge_type = "version"
183183
href = "https://github.com/cpp-linter/cpp-linter/releases/v"
184-
href_title = "Required Version"
184+
href_title = "Minimum Version"
185185

186186
def run(self):
187187
self.badge_icon = load_svg_into_builder_env(
@@ -211,12 +211,13 @@ def run(self):
211211
"1.6.1": ["thread_comments", "no_lgtm"],
212212
"1.6.0": ["step_summary"],
213213
"1.4.7": ["extra_arg"],
214+
"1.8.1": ["jobs"],
214215
}
215216

216217
PERMISSIONS = {
217218
"thread_comments": ["thread-comments", "issues: write"],
218-
"tidy_review": ["pull-request-reviews", "pull_request: write"],
219-
"format_review": ["pull-request-reviews", "pull_request: write"],
219+
"tidy_review": ["pull-request-reviews", "pull-requests: write"],
220+
"format_review": ["pull-request-reviews", "pull-requests: write"],
220221
"files_changed_only": ["file-changes", "contents: read"],
221222
"lines_changed_only": ["file-changes", "contents: read"],
222223
}

docs/permissions.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ The :std:option:`--thread-comments` feature requires the following permissions:
3131
3232
permissions:
3333
issues: write # (1)!
34-
pull_requests: write # (2)!
34+
pull-requests: write # (2)!
3535
3636
.. code-annotations::
3737

@@ -47,4 +47,4 @@ The :std:option:`--tidy-review` and :std:option:`--format-review` features requi
4747
.. code-block:: yaml
4848
4949
permissions:
50-
pull_requests: write
50+
pull-requests: write

0 commit comments

Comments
 (0)