Skip to content

feat: add more clang versions for testing #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 1, 2025
Merged

Conversation

shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Jul 1, 2025

Summary by CodeRabbit

  • Chores
    • Updated pre-commit configuration to include support for multiple versions (16 through 20) of clang-format and clang-tidy.
    • Modified .clang-tidy configuration by commenting out a specific option, reverting it to default behavior.

@shenxianpeng shenxianpeng added the enhancement New feature or request label Jul 1, 2025
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (863f282) to head (421cffc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   77.92%   85.71%   +7.79%     
==========================================
  Files           3        3              
  Lines          77       77              
==========================================
+ Hits           60       66       +6     
+ Misses         17       11       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

coderabbitai bot commented Jul 1, 2025

Warning

Rate limit exceeded

@shenxianpeng has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 145fdda and 421cffc.

📒 Files selected for processing (4)
  • testing/.clang-tidy (0 hunks)
  • testing/run.sh (1 hunks)
  • tests/test_clang_format.py (2 hunks)
  • tests/test_clang_tidy.py (2 hunks)

Walkthrough

The .clang-tidy configuration was updated by commenting out the AnalyzeTemporaryDtors: false line. The pre-commit configuration was expanded to include multiple versions (16 through 20) of clang-format and clang-tidy hooks, allowing these tools to be run with different versions during pre-commit checks.

Changes

File(s) Change Summary
testing/.clang-tidy Commented out the AnalyzeTemporaryDtors: false configuration line.
testing/pre-commit-config-version.yaml Added hooks for clang-format and clang-tidy for versions 17, 18, 19, and 20, in addition to 16.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Pre-commit
    participant Clang-Format-16
    participant Clang-Format-17
    participant Clang-Format-18
    participant Clang-Format-19
    participant Clang-Format-20
    participant Clang-Tidy-16
    participant Clang-Tidy-17
    participant Clang-Tidy-18
    participant Clang-Tidy-19
    participant Clang-Tidy-20

    Developer->>Pre-commit: Run pre-commit hooks
    Pre-commit->>Clang-Format-16: Run formatting check
    Pre-commit->>Clang-Format-17: Run formatting check
    Pre-commit->>Clang-Format-18: Run formatting check
    Pre-commit->>Clang-Format-19: Run formatting check
    Pre-commit->>Clang-Format-20: Run formatting check
    Pre-commit->>Clang-Tidy-16: Run lint check
    Pre-commit->>Clang-Tidy-17: Run lint check
    Pre-commit->>Clang-Tidy-18: Run lint check
    Pre-commit->>Clang-Tidy-19: Run lint check
    Pre-commit->>Clang-Tidy-20: Run lint check
    Pre-commit-->>Developer: Report results for all versions
Loading
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 863f282 and 145fdda.

📒 Files selected for processing (2)
  • testing/.clang-tidy (1 hunks)
  • testing/pre-commit-config-version.yaml (1 hunks)

Copy link

sonarqubecloud bot commented Jul 1, 2025

@shenxianpeng shenxianpeng merged commit c1fb2f3 into main Jul 1, 2025
15 checks passed
@shenxianpeng shenxianpeng deleted the test-more-versions branch July 1, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant