-
Notifications
You must be signed in to change notification settings - Fork 21
Pin v1 to use cpp-linter v1.4.9
#115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We can't run v1 in the test repo because the test repo's CI now uses all platforms supported. Whereas, v1 (as an action not a pkg) can only run on Linux because Github doesn't allow/use docker-based actions on anything but Linux runners.
Given that this still passed on the Linux runners in the test repo, it's ok to merge this. |
OK. I'm going to merge it. |
It also looks like powershell is having a problem with the multiline input that invokes the - name: Run linter as package
id: linter
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: >
cpp-linter
-s=file
-v=9
-i=build
-p=build
-V=${{ runner.temp }}/llvm
-f=false
--extra-arg="-std=c++14 -Wall"
--thread-comments=${{ matrix.clang-version == '12' }}
-a=${{ matrix.clang-version == '12' }} notice |
OK, so my update to the master branch of test-cpp-linter-action repo is incorrect, I thought it maybe not support |
It definitely installed the right version, so I doubt that's a problem with the |
yep, that fixed it, but I had to use a consistent indentation. run: >
cpp-linter
-s=file
-v=9
-i=build
-p=build
-V=${{ runner.temp }}/llvm
-f=false
--extra-arg="-std=c++14 -Wall"
--thread-comments=${{ matrix.clang-version == '12' }}
-a=${{ matrix.clang-version == '12' }} which looks kinda ugly IMHO, but its YAML... I'm not a huge fan of YAML syntax despite my widespread use of it. |
This also include fix #108 to
v1
version