fix: add -DZLIB_USE_STATIC_LIBS=ON to MACOS_CMAKE_ARGS
#50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. ## Walkthrough
The GitHub Actions build workflow for LLVM was updated to add `-DZLIB_USE_STATIC_LIBS=ON` to the macOS CMake arguments. In the macOS build step, a `file` command is run on the renamed `clang-tidy` binary before checking its version. The version check step now includes `continue-on-error: true` to allow the workflow to proceed if the check fails on Clang versions 18 and above. Conditional expressions for artifact upload and draft release steps were simplified by removing the dependabot actor check.
## Changes
| File(s) | Change Summary |
|-----------------------------|--------------------------------------------------------------------------------------------------------------------------------------------|
| .github/workflows/build.yml | Added `-DZLIB_USE_STATIC_LIBS=ON` to macOS CMake args; run `file` on renamed `clang-tidy` binary before version check; added `continue-on-error: true` to `clang-tidy` version check step for macOS builds; simplified conditional expressions for artifact upload and draft release steps by removing dependabot actor check |
## Possibly related PRs
- cpp-linter/clang-tools-static-binaries#46: Updates `.github/workflows/build.yml` to improve macOS build steps including verification after renaming binaries and build flags.
- cpp-linter/clang-tools-static-binaries#42: Modifies GitHub Actions workflows for macOS build environment, adjusting CMake configuration and Homebrew update steps.
- cpp-linter/clang-tools-static-binaries#47: Changes macOS CMake build arguments related to linking, complementing static linking flag additions here.
## Poem
> 🐇 On macOS, the build takes flight,
> Static libs snug, the setup’s tight.
> Clang eighteen and up, a check may fail,
> But bunny hops on without a wail.
> A file command shines a little light,
> Ensuring builds stay smooth and bright!
> 🌿✨Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: build (10, linux)
- GitHub Check: build (14, windows)
- GitHub Check: build (13, linux)
- GitHub Check: build (11, linux)
- GitHub Check: build (11, windows)
- GitHub Check: build (13, windows)
- GitHub Check: build (12.0.1, linux)
- GitHub Check: build (15, linux)
- GitHub Check: build (17, windows)
- GitHub Check: build (15, windows)
- GitHub Check: build (19, windows)
- GitHub Check: build (14, linux)
- GitHub Check: build (17, linux)
- GitHub Check: build (18, linux)
- GitHub Check: build (16, linux)
- GitHub Check: build (18, windows)
- GitHub Check: build (18, macosx)
- GitHub Check: build (19, linux)
- GitHub Check: build (20, linux)
- GitHub Check: build (20, windows)
dyld[72851]: dyld cache '(null)' not loaded: syscall to map cache into shared region failed
dyld[72851]: Library not loaded: /usr/lib/libz.1.dylib
Referenced from: <4272D7CF-D6F9-3021-893C-70E201C19D6D> /Users/runner/work/clang-tools-static-binaries/clang-tools-static-binaries/llvm-project-19.1.0.src/build/bin/clang-tidy-19_macosx-amd64
Reason: tried: '/usr/lib/libz.1.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/lib/libz.1.dylib' (no such file), '/usr/lib/libz.1.dylib' (no such file, no dyld cache), '/usr/local/lib/libz.1.dylib' (no such file)
/Users/runner/work/_temp/68578d7a-dc32-4b82-864c-ec56bdd6de18.sh: line 9: 7[28](https://github.com/cpp-linter/clang-tools-static-binaries/actions/runs/14573665832/job/40875323102?pr=50#step:14:29)51 Abort trap: 6 ./clang-tidy-19_macosx-amd64 --version |
shenxianpeng
changed the title
-DZLIB_USE_STATIC_LIBS=ON to MACOS_CMAKE_ARGS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix the following error on macOS for Clang 19 and 20
Summary by CodeRabbit