Skip to content

Conversation

@shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Aug 13, 2025

closes #99

@shenxianpeng shenxianpeng added the enhancement New feature or request label Aug 13, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 13, 2025
@sonarqubecloud
Copy link

@shenxianpeng shenxianpeng changed the title feat: support arm64 docker images feat: support arm64 and alpine docker images Aug 13, 2025
@shenxianpeng shenxianpeng requested a review from Copilot August 13, 2025 15:52
@shenxianpeng shenxianpeng marked this pull request as ready for review August 13, 2025 15:52
@shenxianpeng shenxianpeng removed the documentation Improvements or additions to documentation label Aug 13, 2025
@shenxianpeng shenxianpeng merged commit e250189 into master Aug 13, 2025
43 checks passed
@shenxianpeng shenxianpeng deleted the feature/support-arm64 branch August 13, 2025 15:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for ARM64 architecture and expands Alpine Linux image variants for clang-tools Docker images. The changes enable multi-platform builds and provide Alpine alternatives for more Node.js versions.

  • Adds ARM64 platform support (linux/arm64) to all existing Docker targets
  • Extends Alpine image variants to include versions 17, 18, 19, and 20 (previously only version 16 was available)
  • Updates CI workflow to build and test the new Alpine image variants

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docker-bake.hcl Adds ARM64 platform support to all targets and expands Alpine matrix to include versions 17-20
README.md Documents the new Alpine image variants (17-alpine, 18-alpine, 19-alpine, 20-alpine)
.github/workflows/CI.yml Updates build matrix to include the new Alpine image targets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

platforms = ["linux/amd64", "linux/arm64"]
}

target "clang-tools" {
Copy link

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple targets with the same name "clang-tools" defined. This will cause conflicts as target names must be unique in Docker Bake files.

Suggested change
target "clang-tools" {
target "clang-tools-19" {

Copilot uses AI. Check for mistakes.
shenxianpeng added a commit that referenced this pull request Aug 13, 2025
* feat: support arm64 and alpine docker images (#100)

* feat: support arm64 docker images

* feat: support more alpine images

* fix: add arm64 and alpine images

* feat: add alpine images to ci

* docs: update readme

* remove condition to test

* add output = [type=registry]

* remove --load option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add build for arm64

2 participants