Expand examples#8
Conversation
|
|
||
| constexpr auto foo = forest::literal<64>("<rgb=500><b><i>hello</b></i></rgb> world"); | ||
|
|
||
| void with_temp_file(std::function<void(std::FILE*)> const fn) { |
There was a problem hiding this comment.
Use a template parameter typename F instead of std::function? It's quite heavy and mostly unnecessary here.
There was a problem hiding this comment.
Should I add an std::is_invocable_v check as well?
There was a problem hiding this comment.
Up to you! Since this is example "client side" code, it's not very important; different story if it were a library function.
|
|
||
| fn(temp_file); | ||
|
|
||
| std::fclose(temp_file); |
There was a problem hiding this comment.
This is currently a bit unsafe: eg, if fn throws, the file will remain locked and undeleted. I'd suggest wrapping the "close" logic into a lambda, and temp_file into std::unique_ptr<std::FILE*, decltype(close_file)>. That way the file will always be closed on destruction of the unique ptr / the function returning (even if it unwinds due to a throw).
| int main() { | ||
| std::cout << foo << '\n'; | ||
|
|
||
| std::cout << forest::literal<71>("I <strike>copy</strike> <b>study</b> code from <u>stackoverflow.com</u>") << '\n'; |
There was a problem hiding this comment.
Might want to reduce the number of magic numbers a bit; eg use forest::length() for one or two?
There was a problem hiding this comment.
How does it differ from say a call to std::string_view::size?
There was a problem hiding this comment.
forest::length will compute the size of the string after all replacements have been done. Ideally the library would call this first, figure out the required size, and then return a literal of that size, all at compile time. But getting that to work is largely impossible in C++17. Still, something like this is possible, although not great:
constexpr auto text = "<b>hi</b>";
constexpr auto output = forest::literal<forest::length(text)>(text);| forest::format_to(std::back_inserter(ft), "<b><rgb=155>Hello from the string!</rgb></b>"); | ||
| std::cout << ft << '\n'; | ||
|
|
||
| with_temp_file([](std::FILE* const tf) { |
There was a problem hiding this comment.
Nice pattern! Inspired from Python?
| void with_temp_file(std::function<void(std::FILE*)> const fn) { | ||
| template <typename F> | ||
| void with_temp_file(F const fn) { | ||
| constexpr auto tf_name = "temp.txt"; |
There was a problem hiding this comment.
Suggestion: make this static to auto capture it.
|
Close #3 |
2 participants
No description provided.