Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: package layout #368

Merged
merged 2 commits into from
Mar 17, 2019
Merged

fix: package layout #368

merged 2 commits into from
Mar 17, 2019

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Mar 12, 2019

closes #358

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #368 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files          31       31           
  Lines        3107     3107           
=======================================
  Hits         2704     2704           
  Misses        403      403

1 similar comment
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #368 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files          31       31           
  Lines        3107     3107           
=======================================
  Hits         2704     2704           
  Misses        403      403

@codecov
Copy link

codecov bot commented Mar 12, 2019 •
edited
Loading

Codecov Report

Merging #368 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   87.02%   87.05%   +0.02%     
==========================================
  Files          31       31              
  Lines        3107     3114       +7     
==========================================
+ Hits         2704     2711       +7     
  Misses        403      403

@MarcoRossignoli MarcoRossignoli requested a review from tonerdo March 12, 2019 11:12
@MarcoRossignoli
Copy link
Collaborator

/cc @sharwell

sharwell
sharwell approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should correct the issue with .NET 4.5-4.6.

@sharwell @viceice
remove trailing backslash
ad4cecf 
Co-Authored-By: ViceIce <michael.kriese@visualon.de>
@tonerdo tonerdo merged commit 10e9a62 into coverlet-coverage:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@tonerdo tonerdo tonerdo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coverlet.msbuild does not work for projects targeting .NET Framework 4.6
4 participants
@viceice @MarcoRossignoli @sharwell @tonerdo