Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filename update for activated UseSourceFile option #1681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bertk
Copy link
Collaborator

@Bertk Bertk commented Aug 6, 2024

fixes #1679

@Bertk Bertk marked this pull request as ready for review August 6, 2024 08:02
@Bertk Bertk changed the title always update filename with activated UseSourceFile option fix filename update for activated UseSourceFile option Aug 15, 2024
@@ -386,6 +376,16 @@ private void CalculateCoverage()
}
}

if (!_fileSystem.Exists(result.HitsFilePath))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue #1679 describes the problem and changing the sequence make sure the file name for activated SourceLink option is always updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inconsistent filenames with UseSourceLink after .NET 8
2 participants