enable skipped tests (#1750)

* enable skipped tests

* skip AsyncAwait_Issue_669_2 on Windows

* Update global.json

* update SDK and nuget package versions

Author: Bertk

.gitignore

@@ -318,3 +318,4 @@ FolderProfile.pubxml
 /NuGet.config
 nuget.config
 *.dmp
+Playground*/

Directory.Packages.props

@@ -54,18 +54,18 @@
     <PackageVersion Include="Tmds.ExecFunction" Version="0.8.0" />
     <PackageVersion Include="xunit.v3" Version="$(XunitV3Version)" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="$(XunitRunnerVisualstudioVersion)" />
-    <PackageVersion Include="System.Buffers" Version="4.6.0" />
+    <PackageVersion Include="System.Buffers" Version="4.6.1" />
     <PackageVersion Include="System.Collections.Immutable" Version="8.0.0" />
-    <PackageVersion Include="System.Configuration.ConfigurationManager" Version="8.0.0" />
-    <PackageVersion Include="System.Linq.Async" Version="6.0.1" />
-    <PackageVersion Include="System.Memory" Version="4.6.0" />
+    <PackageVersion Include="System.Configuration.ConfigurationManager" Version="8.0.1" />
+    <PackageVersion Include="System.Linq.Async" Version="6.0.3" />
+    <PackageVersion Include="System.Memory" Version="4.6.3" />
     <PackageVersion Include="System.Net.Http" Version="4.3.4" />
     <PackageVersion Include="System.Reflection.Metadata" Version="8.0.1" />
-    <PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.1.0" />
-    <PackageVersion Include="System.Security.Cryptography.Pkcs" Version="6.0.5" />
+    <PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.1.2" />
+    <PackageVersion Include="System.Security.Cryptography.Pkcs" Version="8.0.1" />
     <PackageVersion Include="System.Text.Encoding.CodePages" Version="8.0.0" />
-    <PackageVersion Include="System.Text.Json" Version="8.0.5" />
+    <PackageVersion Include="System.Text.Json" Version="8.0.6" /> <!-- used by tests -->
     <PackageVersion Include="System.Text.RegularExpressions" Version="4.3.1" />
-    <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.6.0" />
+    <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.6.3" />
   </ItemGroup>
 </Project>

eng/azure-pipelines-nightly.yml

@@ -10,7 +10,7 @@ steps:
 - task: UseDotNet@2
   inputs:
     useGlobalJson: true
-  displayName: Install .NET Core SDK 8.0.113
+    displayName: Use .NET SDK from global.json
 
 - task: NuGetAuthenticate@1
   displayName: Authenticate with NuGet feeds

eng/build.yml

@@ -7,7 +7,7 @@ steps:
 - task: UseDotNet@2
   inputs:
     useGlobalJson: true
-  displayName: Install .NET Core SDK 8.0.113
+  displayName: Install .NET Core SDK (global.json)
 
 # create artifact/package folder
 - pwsh: |

global.json

@@ -1,5 +1,5 @@
 {
     "sdk": {
-        "version": "8.0.407"
+        "version": "8.0.412"
     }
 }

test/coverlet.core.coverage.tests/Coverage/CoverageTests.AsyncAwait.cs

@@ -3,6 +3,7 @@
 
 using System.IO;
 using System.Reflection;
+using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
 using Coverlet.Core;
@@ -102,9 +103,11 @@ public void AsyncAwait_Issue_669_1()
       }
     }
 
-    [Fact(Skip = "Unhandled exception: System.InvalidOperationException: Sequence contains more than one matching element, InstrumenterHelper.cs:line 139 ")]
+    [Fact]
     public void AsyncAwait_Issue_669_2()
     {
+      // fails on CI with Windows OS - unknown reason - successfully executed locally (CLI)
+      Assert.SkipWhen(RuntimeInformation.IsOSPlatform(OSPlatform.Windows), "This test is skipped on Windows for CI environment");
       string path = Path.GetTempFileName();
       try
       {

test/coverlet.core.coverage.tests/Coverage/CoverageTests.DoesNotReturn.cs

@@ -47,7 +47,7 @@ public void NoBranches_DoesNotReturnAttribute_InstrumentsCorrect()
       }
     }
 
-    [Fact(Skip = "xunit.v3 '(Explicit=true)' (System.Console.ReadKey, Instrumentation.DoesNotReturn.cs line 22) ")]
+    [Fact]
     public void If_DoesNotReturnAttribute_InstrumentsCorrect()
     {
       string path = Path.GetTempFileName();
@@ -78,7 +78,7 @@ public void If_DoesNotReturnAttribute_InstrumentsCorrect()
       }
     }
 
-    [Fact(Skip = "xunit.v3 '(Explicit=true)' (System.Console.ReadKey, Instrumentation.DoesNotReturn.cs line 36) ")]
+    [Fact]
     public void Switch_DoesNotReturnAttribute_InstrumentsCorrect()
     {
       string path = Path.GetTempFileName();
@@ -109,7 +109,7 @@ public void Switch_DoesNotReturnAttribute_InstrumentsCorrect()
       }
     }
 
-    [Fact(Skip = "xunit.v3 '(Explicit=true)' (System.Console.ReadKey, Instrumentation.DoesNotReturn.cs line 37) ")]
+    [Fact]
     public void Subtle_DoesNotReturnAttribute_InstrumentsCorrect()
     {
       string path = Path.GetTempFileName();
@@ -140,7 +140,7 @@ public void Subtle_DoesNotReturnAttribute_InstrumentsCorrect()
       }
     }
 
-    [Fact(Skip = "xunit.v3 '(Explicit=true)' (System.Console.ReadKey, Instrumentation.DoesNotReturn.cs line 107) ")]
+    [Fact]
     public void UnreachableBranch_DoesNotReturnAttribute_InstrumentsCorrect()
     {
       string path = Path.GetTempFileName();

test/coverlet.integration.tests/coverlet.integration.tests.csproj

@@ -23,8 +23,8 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>
     <PackageReference Include="System.Reflection.Metadata" Version="8.0.1" />
-    <PackageReference Include="System.Security.Cryptography.Pkcs" Version="6.0.5" />
-    <PackageReference Include="System.Text.Json" Version="8.0.5" />
+    <PackageReference Include="System.Security.Cryptography.Pkcs" Version="8.0.1" />
+    <PackageReference Include="System.Text.Json" Version="8.0.6" />
   </ItemGroup>
 
   <ItemGroup>