Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coveo-settings // should support settings as fallback #95

Open
jonapich opened this issue Oct 27, 2021 · 0 comments
Open

coveo-settings // should support settings as fallback #95

jonapich opened this issue Oct 27, 2021 · 0 comments
Labels
coveo-settings enhancement New feature or request

Comments

@jonapich
Copy link
Collaborator

You should be able to set another Setting instance as a fallback, and retain the dynamic capabilities.

The first step is to change the typing of the fallback argument to accept Settings instances.

Then, we need to be smart about when we e.g. str(fallback) since it could be NotSet at this point. When the user uses .value to obtain the value we need to ensure we don't trigger the NotSet exception either.

@jonapich jonapich added coveo-settings enhancement New feature or request labels Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coveo-settings enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant