Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty namespaces need to be added to validNamespaces #4

Open
tomasherman opened this issue Jul 14, 2021 · 1 comment
Open

Empty namespaces need to be added to validNamespaces #4

tomasherman opened this issue Jul 14, 2021 · 1 comment

Comments

@tomasherman
Copy link

Hello,

Thanks for this plugin! I'm trying to use shading in one of our project and it seems that empty packages must be added to validNamespaces. Is that intended?

It seems to lead (at least in my case) to adding packages like com and org and io to the validNamespaces, which kinda defeats the point of this validation in my opinion as it will whitelist pretty much anything. Am i missing something?

I think it would make sense to apply validNamespaces only to filenames, not directories.
@guizmaii
Copy link
Contributor

Agreed. Just bumped into the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomasherman @guizmaii