Change the error issed for array modifiers appearing on both the type and variable name to match the behavior of VBC.

Author: lee-m

vbnc/vbnc/source/General/Messages.vb

@@ -4643,7 +4643,7 @@ Public Enum Messages
     <Message(MessageLevel.Error)> VBNC31086 = 31086
 
     ''' <summary>
-    ''' VBNC = "A variable can't declare array modifiers both on the variable name and on the type."
+    ''' VBNC = "Array modifiers cannot be specified on both a variable and its type."
     ''' VB   = "Array modifiers cannot be specified on both a variable and its type."
     ''' </summary>
     ''' <remarks></remarks>
@@ -6946,4 +6946,3 @@ Public Enum Messages
     <Message(MessageLevel.Error)> VBNC99999 = 99999
 
 End Enum
-

vbnc/vbnc/source/Members/VariableDeclaration.vb

@@ -175,7 +175,7 @@ Public MustInherit Class VariableDeclaration
 
         If m_VariableIdentifier IsNot Nothing AndAlso m_VariableIdentifier.HasArrayNameModifier Then
             If CecilHelper.IsArray(m_VariableType) Then
-                result = Helper.AddError(Me, "Cannot specify array modifier on both type name and on variable name.") AndAlso result
+                result = Compiler.Report.ShowMessage(Messages.VBNC31087, Location) AndAlso result
             Else
                 If m_VariableIdentifier.ArrayNameModifier.IsArraySizeInitializationModifier Then
                     m_VariableType = m_VariableIdentifier.ArrayNameModifier.AsArraySizeInitializationModifier.CreateArrayType(m_VariableType)

vbnc/vbnc/source/Resources/Errors.resx

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!-- 
     Microsoft ResX Schema 
@@ -112,10 +112,10 @@
     <value>2.0</value>
   </resheader>
   <resheader name="reader">
-    <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
   <resheader name="writer">
-    <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
   <data name="warning" xml:space="preserve">
     <value>'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
@@ -2105,7 +2105,7 @@
     <value>CHANGEME</value>
   </data>
   <data name="31087" xml:space="preserve">
-    <value>A variable can't declare array modifiers both on the variable name and on the type.</value>
+    <value>Array modifiers cannot be specified on both a variable and its type.</value>
   </data>
   <data name="31088" xml:space="preserve">
     <value>CHANGEME</value>
@@ -3091,5 +3091,4 @@
   <data name="99999" xml:space="preserve">
     <value>{0}</value>
   </data>
-</root>
-
+</root>

vbnc/vbnc/source/Resources/Source.xml

@@ -3309,7 +3309,7 @@
 	</Message>
 	<Message id="31087" level="Error">
 		<Comment>NC</Comment>
-		<VBNCValue>A variable can't declare array modifiers both on the variable name and on the type.</VBNCValue>
+		<VBNCValue>Array modifiers cannot be specified on both a variable and its type.</VBNCValue>
 		<VBValue>Array modifiers cannot be specified on both a variable and its type.</VBValue>
 	</Message>
 	<Message id="31088" level="Error">

vbnc/vbnc/tests/Errors/31087.vb

@@ -0,0 +1,9 @@
+Module Test
+
+	Sub Foo()
+	  
+		Dim a() As String()
+		
+	End Sub
+	
+End Module

vbnc/vbnc/tests/tests.xml

@@ -24247,4 +24247,9 @@
 		<file>Errors\30057-2.vb</file>
 		<error line="11" number="30057" message="Too many arguments to 'Public Sub Z()'." />
 	</test>
+	<test id="3133" name="31087" expectedexitcode="1" expectedvbcexitcode="1" mytype="empty">
+		<file>Errors\31087.vb</file>
+		<error line="5" number="31087" message="Array modifiers cannot be specified on both a variable and its type." />
+		<vbcerror line="5" number="31087" message="Array modifiers cannot be specified on both a variable and its type." />
+	</test>
 </rt>