Skip to content

DOC-3770 #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2018
Merged

DOC-3770 #2799

merged 4 commits into from
Aug 7, 2018

Conversation

RichardSmedley
Copy link
Contributor

No description provided.

@cb-docs-robot
Copy link
Contributor

Build for this PR failed - dita conversion returned errors. Please review the result at http://docs-build.sc.couchbase.com:8080/job/Server/job/pull-requests/job/build-pr/4002/parsed_console/ and fix the issues prior to merging.

@cb-docs-robot
Copy link
Contributor

Content is up for review at http://docs-build.sc.couchbase.com/server/2799.
Changed files:

If any of the links return a 404, then the file is not in the ditamap.

@RichardSmedley RichardSmedley requested a review from a team August 6, 2018 08:02
Copy link
Contributor

@tonyjhillman tonyjhillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In "Creating Documents", the default bucket should not be used or referenced, since it is pre-5.0.

In "Reading Documents by Querying", 'criteria' should be 'criterion'.

The example sentence starting with "Give me" needs the question-mark at the end removing.

In "Couchbase clients", I would suggest a comma after 'SDK' and before 'which'.

@cb-docs-robot
Copy link
Contributor

Content is up for review at http://docs-build.sc.couchbase.com/server/2799.
Changed files:

If any of the links return a 404, then the file is not in the ditamap.

@cb-docs-robot
Copy link
Contributor

Content is up for review at http://docs-build.sc.couchbase.com/server/2799.
Changed files:

If any of the links return a 404, then the file is not in the ditamap.

@RichardSmedley RichardSmedley merged commit 4b0e2be into vulcan Aug 7, 2018
@RichardSmedley RichardSmedley deleted the RichardSmedley-patch-1 branch August 16, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants