Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: couchbase/couchbase-python-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: couchbase/couchbase-python-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release23
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 27, 2018

  1. PYCBC-472: Evaluate/merge PR: "TypeError: _assign_kwargs() got an une… 

    …xpected keyword argument 'distance'"

As per title:

At the moment when you try to use `GeoDistanceQuery` you will get:
```sh
Traceback (most recent call last):
  File "test.py", line 208, in <module>
    for city in cities:
  File "test.py", line 103, in get_by_coordinates
    GeoDistanceQuery('1km', (lon, lat)),
  File "/my-path/venv/lib/python3.6/site-packages/couchbase/fulltext.py", line 697, in __init__
    _assign_kwargs(self, **kwargs)
TypeError: _assign_kwargs() got an unexpected keyword argument 'distance'
```

That fixes this problem.

Change-Id: Ic1e2a0dedba9bfd53d749dba6507442f6abbaf52
Reviewed-on: http://review.couchbase.org/90858
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Ellis Breen <ellis.breen@couchbase.com>
Reviewed-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Reviewed-on: http://review.couchbase.org/93439
    @whisller @MikeGoldsmith
    whisller authored and MikeGoldsmith committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    999057b View commit details
    Browse the repository at this point in the history

  2. PYCBC-477: Update PrefixQuery to allow unicode characters 

    Updated PrefixQuery to use _genprop_str so that unicode characters
do not raise an unnecessary conversion exception.

Change-Id: I22d7265ee36d35545fbe7bf1c6d5339ea980ba0d
Reviewed-on: http://review.couchbase.org/92632
Reviewed-by: Ellis Breen <ellis.breen@couchbase.com>
Reviewed-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Tested-by: Build Bot <build@couchbase.com>
Reviewed-on: http://review.couchbase.org/93440
    @MikeGoldsmith
    Dave Starling authored and MikeGoldsmith committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    8216ec7 View commit details
    Browse the repository at this point in the history
Loading