CXXCBC-194 Support ExtThreadSafe transaction extension. #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While at it, updated the public version of transaction_get_result to not strip out the metadata and links, as they are needed when staging replace/remove operations. Also, the fit tests would sometimes run into issues with the naive retry strategy when there was a FAIL_AMBIGUOUS while setting the ATR. Redid the transaction_context's utility for delaying to no longer be recursive, avoiding the issue. There are other places where this strategy should be used in the future, in the utilities that do the various forms of delay and exponential backoff, which I'll create a ticket to improve later.
avsej
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While at it, updated the public version of transaction_get_result to not strip out the metadata and links, as they are needed when staging replace/remove operations.
Also, the fit tests would sometimes run into issues with the naive retry
strategy when there was a FAIL_AMBIGUOUS while setting the ATR. Redid
the transaction_context's utility for delaying to no longer be
recursive, avoiding the issue. There are other places where this
strategy should be used in the future, in the utilities that do the
various forms of delay and exponential backoff, which I'll create a
ticket to improve later.